You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/26 02:02:48 UTC

[GitHub] [pulsar] kristi opened a new pull request #7666: [docs] Add double dash to kubectl exec commands

kristi opened a new pull request #7666:
URL: https://github.com/apache/pulsar/pull/7666


   ### Motivation
   
   kubectl 1.18.6 warns that not using the double dashes is deprecated. Adding the double dashes to the kubectl exec commands in the docs will remove this warning and future-proof the commands if kubectl drops support for running a command without the double dashes.
   
   ### Modifications
   
   Documentation update
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #7666: [docs] Add double dash to kubectl exec commands

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7666:
URL: https://github.com/apache/pulsar/pull/7666


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] kristi commented on pull request #7666: [docs] Add double dash to kubectl exec commands

Posted by GitBox <gi...@apache.org>.
kristi commented on pull request #7666:
URL: https://github.com/apache/pulsar/pull/7666#issuecomment-664049603


   not sure why the cpp tests failed, this doesn't touch any code, so must be something else going on


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org