You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ji...@apache.org on 2019/02/07 00:53:44 UTC
[incubator-pinot] branch master updated: [TE] frontend -
harleyjj/yaml-editor - link Documentation buttons to YAML Documentation
(#3800)
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e121b83 [TE] frontend - harleyjj/yaml-editor - link Documentation buttons to YAML Documentation (#3800)
e121b83 is described below
commit e121b830e393cf9467dd600031107908269f0bb0
Author: Harley Jackson <ha...@gmail.com>
AuthorDate: Wed Feb 6 16:53:38 2019 -0800
[TE] frontend - harleyjj/yaml-editor - link Documentation buttons to YAML Documentation (#3800)
YAML Documentation
---
.../modals/yaml-documentation/component.js | 36 ----------------------
.../modals/yaml-documentation/template.hbs | 12 --------
.../app/pods/components/yaml-editor/component.js | 10 +++---
.../app/pods/components/yaml-editor/template.hbs | 14 +++------
4 files changed, 10 insertions(+), 62 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/modals/yaml-documentation/component.js b/thirdeye/thirdeye-frontend/app/pods/components/modals/yaml-documentation/component.js
deleted file mode 100644
index d8541a3..0000000
--- a/thirdeye/thirdeye-frontend/app/pods/components/modals/yaml-documentation/component.js
+++ /dev/null
@@ -1,36 +0,0 @@
-import Component from '@ember/component';
-import { computed, set, get, getProperties } from '@ember/object';
-
-export default Component.extend({
-
- showYAMLModal: computed(
- 'showAnomalyModal',
- 'showNotificationModal',
- function() {
- const {
- showAnomalyModal,
- showNotificationModal
- } = getProperties(this, 'showAnomalyModal', 'showNotificationModal');
- return showAnomalyModal || showNotificationModal;
- }
- ),
-
- headerText: computed(
- 'YAMLField',
- function() {
- const YAMLField = get(this, 'YAMLField');
- return `YAML ${YAMLField} Documentation`;
- }
- ),
-
- actions: {
- /**
- * Handles the close event
- * @return {undefined}
- */
- onExit() {
- let YAMLField = get(this, 'YAMLField');
- set(this, `show${YAMLField}Modal`, false);
- }
- }
-});
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/modals/yaml-documentation/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/modals/yaml-documentation/template.hbs
deleted file mode 100644
index 5f98fc8..0000000
--- a/thirdeye/thirdeye-frontend/app/pods/components/modals/yaml-documentation/template.hbs
+++ /dev/null
@@ -1,12 +0,0 @@
-{{#te-modal
- headerText=headerText
- isShowingModal=showYAMLModal
- cancelAction=(action "onExit")
- hasFooter=false
-}}
- <div class="row te-modal__settings">
- <p class="col-md-2">
- <span class="te-label te-label--bold te-label--dark">YAML Documentation Coming soon...</span>
- </p>
- </div>
-{{/te-modal}}
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
index fe6e51b..c19ab8e 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
@@ -56,7 +56,6 @@ export default Component.extend({
yamlAlertSettings: yamlAlertSettings,
showAnomalyModal: false,
showNotificationModal: false,
- YAMLField: '',
currentYamlAlertOriginal: '',
currentYamlSettingsOriginal: '',
toggleCollapsed: true,
@@ -267,9 +266,12 @@ export default Component.extend({
/**
* Brings up appropriate modal, based on which yaml field is clicked
*/
- triggerDocModal(field) {
- set(this, `show${field}Modal`, true);
- set(this, 'YAMLField', field);
+ triggerDoc(field) {
+ if (field === 'Anomaly') {
+ window.open('https://iwww.corp.linkedin.com/wiki/cf/display/ENGS/ThirdEye+Alert+Configuration+Reference#ThirdEyeAlertConfigurationReference-2.WriteAnomaly-Function/DetectionConfiguration');
+ } else {
+ window.open('https://iwww.corp.linkedin.com/wiki/cf/display/ENGS/ThirdEye+Alert+Configuration+Reference#ThirdEyeAlertConfigurationReference-3.WriteSubscription-Group/NotificationConfiguration');
+ }
},
/**
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
index 56bb47f..c442036 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
@@ -21,8 +21,8 @@
{{bs-button
defaultText="View Documentation"
type="outline-primary"
- buttonType="modal"
- onClick=(action "triggerDocModal" "Anomaly")
+ buttonType="link"
+ onClick=(action "triggerDoc" "Anomaly")
class="te-button te-button--cancel"
}}
</div>
@@ -93,8 +93,8 @@
{{bs-button
defaultText="View Documentation"
type="outline-primary"
- buttonType="modal"
- onClick=(action "triggerDocModal" "Notification")
+ buttonType="link"
+ onClick=(action "triggerDoc" "Notification")
class="te-button te-button--cancel"
}}
</div>
@@ -140,9 +140,3 @@
}}
{{/if}}
</fieldset>
-
-{{modals/yaml-documentation
- showAnomalyModal=showAnomalyModal
- showNotificationModal=showNotificationModal
- YAMLField=YAMLField
-}}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org