You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2011/06/30 19:22:28 UTC

[jira] [Created] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

OrderedConfiguration should have methods to make it easy to add elements in sequential order
--------------------------------------------------------------------------------------------

                 Key: TAP5-1565
                 URL: https://issues.apache.org/jira/browse/TAP5-1565
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-ioc
    Affects Versions: 5.3
            Reporter: Howard M. Lewis Ship
            Priority: Minor


It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.

Example:

  configuration.add("item1", new Item1());
  configuration.addSequential("item2", new Item2());
  configuration.addInstanceSequential("item3", Item3.class);

This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.

It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.

Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057959#comment-13057959 ] 

Robert Zeigler commented on TAP5-1565:
--------------------------------------

It probably has the potential to break some code where there are ordering constraints specified, but perhaps not enough to precisely lock down the ordering where it needs to be.  I know when upgrading an app from 5.0.x to 5.1.x that I had some situations like that, where my original ordering constraints were suddenly insufficient (I think new services in Tapestry created new ambiguities in the ordering).  That said, even given the risk of breaking apps, I would take the implicit ordering over random ordering because it will mean greater ordering stability in the future.

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068646#comment-13068646 ] 

Hudson commented on TAP5-1565:
------------------------------

Integrated in tapestry-trunk-freestyle #425 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/425/])
    TAP5-1565: OrderedConfiguration should have methods to make it easy to add elements in sequential order

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148905
Files : 
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ValidatingOrderedConfigurationWrapper.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/FredModule.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/ValidatingOrderedConfigurationWrapperTest.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/RegistryImpl.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/OrderedConfiguration.java


> It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057959#comment-13057959 ] 

Robert Zeigler commented on TAP5-1565:
--------------------------------------

It probably has the potential to break some code where there are ordering constraints specified, but perhaps not enough to precisely lock down the ordering where it needs to be.  I know when upgrading an app from 5.0.x to 5.1.x that I had some situations like that, where my original ordering constraints were suddenly insufficient (I think new services in Tapestry created new ambiguities in the ordering).  That said, even given the risk of breaking apps, I would take the implicit ordering over random ordering because it will mean greater ordering stability in the future.

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1565) It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-1565:
---------------------------------------

    Summary: It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer  (was: OrderedConfiguration should have methods to make it easy to add elements in sequential order)

Also, I've updated the wiki.

> It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reopened TAP5-1565:
----------------------------------------


> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1565) It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1565.
--------------------------------------

    Resolution: Fixed

> It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1565:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1565) It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1565.
--------------------------------------

    Resolution: Fixed

> It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1565.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057951#comment-13057951 ] 

Howard M. Lewis Ship commented on TAP5-1565:
--------------------------------------------

That's prettty cool ... so no explicit ordering supplies "after last added item, whatever that is". That shouldn't break any existing code, because if you don't specify an ordering constraint, it means you don't care where in the final list it is ordered, and so sequential ordering should be just as good as arbitrary.

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057951#comment-13057951 ] 

Howard M. Lewis Ship commented on TAP5-1565:
--------------------------------------------

That's prettty cool ... so no explicit ordering supplies "after last added item, whatever that is". That shouldn't break any existing code, because if you don't specify an ordering constraint, it means you don't care where in the final list it is ordered, and so sequential ordering should be just as good as arbitrary.

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1565.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Josh Canfield (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057943#comment-13057943 ] 

Josh Canfield commented on TAP5-1565:
-------------------------------------

Instead of adding a new method, can we just consider add(String, Object) to be sequential? 

I can't see that breaking any existing code.

  configuration.add("item1", new Item1()); 
  configuration.add("item2", new Item2()); 
  configuration.add("item3", new Item3());
  configuration.add("before2", new Item4(), "before:item2");

Results in:

[
  Item1(),
  Item4(),
  Item2(),
  Item3()
]
 


> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1565:
------------------------------------------

    Assignee: Howard M. Lewis Ship

> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1565) It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-1565:
---------------------------------------

    Summary: It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer  (was: OrderedConfiguration should have methods to make it easy to add elements in sequential order)

Also, I've updated the wiki.

> It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reopened TAP5-1565:
----------------------------------------


> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068646#comment-13068646 ] 

Hudson commented on TAP5-1565:
------------------------------

Integrated in tapestry-trunk-freestyle #425 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/425/])
    TAP5-1565: OrderedConfiguration should have methods to make it easy to add elements in sequential order

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148905
Files : 
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/ValidatingOrderedConfigurationWrapper.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/FredModule.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/ValidatingOrderedConfigurationWrapperTest.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/RegistryImpl.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/OrderedConfiguration.java


> It should be easier to make a series of contributions to an OrderedConfiguration so that the contributions are in sequential orderer
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.3
>
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1565) OrderedConfiguration should have methods to make it easy to add elements in sequential order

Posted by "Josh Canfield (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057943#comment-13057943 ] 

Josh Canfield commented on TAP5-1565:
-------------------------------------

Instead of adding a new method, can we just consider add(String, Object) to be sequential? 

I can't see that breaking any existing code.

  configuration.add("item1", new Item1()); 
  configuration.add("item2", new Item2()); 
  configuration.add("item3", new Item3());
  configuration.add("before2", new Item4(), "before:item2");

Results in:

[
  Item1(),
  Item4(),
  Item2(),
  Item3()
]
 


> OrderedConfiguration should have methods to make it easy to add elements in sequential order
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1565
>                 URL: https://issues.apache.org/jira/browse/TAP5-1565
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> It is not uncommon to have a series of elements to add to an OrderedConfiguration in a specific order; it would be nice if there was a way to add sequential items without manually tracking each nodes name and adding "after:" clauses.
> Example:
>   configuration.add("item1", new Item1());
>   configuration.addSequential("item2", new Item2());
>   configuration.addInstanceSequential("item3", Item3.class);
> This would simply add an "after:item1" ordering constraint for item2, and an "after:item3" constraint for item3.
> It should be legal to add an item sequentially, even if there is no previously added item (added in this contribution method, or elsewhere), in which case, no ordering constraint it added.
> Would "next" and "nextInstance" be better than "addSequential" and "addInstanceSequential"?  I'm open to other suggestions on the naming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira