You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "maheshrajus (via GitHub)" <gi...@apache.org> on 2026/07/14 12:03:14 UTC
[PR] TEZ-4736: Fix flaky TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession [tez]
maheshrajus opened a new pull request, #521:
URL: https://github.com/apache/tez/pull/521
#### Root causes and fixes:
TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession **(DAG SUCCEEDED ≠ AM READY)**
In session mode, DAG reaching SUCCEEDED does not mean the AM session has
transitioned back to READY. there is a short cleanup window.
On slow CI the subsequent getAppMasterStatus() call returned RUNNING instead of READY.
Add tezSession.waitTillReady() before each assertEquals(READY, ...) so
the test waits for the actual state transition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4736: Fix flaky TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession [tez]
Posted by "maheshrajus (via GitHub)" <gi...@apache.org>.
maheshrajus commented on code in PR #521:
URL: https://github.com/apache/tez/pull/521#discussion_r3631035535
##########
tez-tests/src/test/java/org/apache/tez/mapreduce/TestMRRJobsDAGApi.java:
##########
@@ -400,16 +400,24 @@ public void testAMRelocalization() throws Exception {
additionalResources.put("test.jar", createLrObjFromPath(relocFilePath));
additionalResources.put("TezAppJar.jar", createLrObjFromPath(tezAppJarRemote));
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
finalState = testMRRSleepJobDagSubmitCore(true, false, false,
tezSession, true, MRInputAMSplitGeneratorRelocalizationTest.class, additionalResources);
assertEquals(DAGStatus.State.SUCCEEDED, finalState);
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
assertTrue(remoteFs.exists(new Path("/tmp/relocalizationfilefound")));
stopAndVerifyYarnApp(tezSession);
}
+ private void waitForSessionReady(TezClient tezSession)
+ throws IOException, TezException, InterruptedException {
+ boolean ready = tezSession.waitTillReady(60, TimeUnit.SECONDS);
Review Comment:
Done. I kept 10s as waiting time for session ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4736: Fix flaky TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #521:
URL: https://github.com/apache/tez/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4736: Fix flaky TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #521:
URL: https://github.com/apache/tez/pull/521#issuecomment-5047868081
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 42m 57s | | Docker mode activated. |
| -1 :x: | patch | 0m 1s | | /precommit/extras/patch does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-521/2/artifact/out/Dockerfile |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-521/2/console |
| versions | git=2.43.0 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4736: Fix flaky TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession [tez]
Posted by "maheshrajus (via GitHub)" <gi...@apache.org>.
maheshrajus commented on code in PR #521:
URL: https://github.com/apache/tez/pull/521#discussion_r3631032020
##########
tez-tests/src/test/java/org/apache/tez/mapreduce/TestMRRJobsDAGApi.java:
##########
@@ -400,16 +400,24 @@ public void testAMRelocalization() throws Exception {
additionalResources.put("test.jar", createLrObjFromPath(relocFilePath));
additionalResources.put("TezAppJar.jar", createLrObjFromPath(tezAppJarRemote));
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
finalState = testMRRSleepJobDagSubmitCore(true, false, false,
tezSession, true, MRInputAMSplitGeneratorRelocalizationTest.class, additionalResources);
assertEquals(DAGStatus.State.SUCCEEDED, finalState);
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
assertTrue(remoteFs.exists(new Path("/tmp/relocalizationfilefound")));
stopAndVerifyYarnApp(tezSession);
}
+ private void waitForSessionReady(TezClient tezSession)
Review Comment:
Done. Method renamed to "waitAndAssertSessionReady"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4736: Fix flaky TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #521:
URL: https://github.com/apache/tez/pull/521#discussion_r3623478982
##########
tez-tests/src/test/java/org/apache/tez/mapreduce/TestMRRJobsDAGApi.java:
##########
@@ -400,16 +400,24 @@ public void testAMRelocalization() throws Exception {
additionalResources.put("test.jar", createLrObjFromPath(relocFilePath));
additionalResources.put("TezAppJar.jar", createLrObjFromPath(tezAppJarRemote));
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
finalState = testMRRSleepJobDagSubmitCore(true, false, false,
tezSession, true, MRInputAMSplitGeneratorRelocalizationTest.class, additionalResources);
assertEquals(DAGStatus.State.SUCCEEDED, finalState);
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
assertTrue(remoteFs.exists(new Path("/tmp/relocalizationfilefound")));
stopAndVerifyYarnApp(tezSession);
}
+ private void waitForSessionReady(TezClient tezSession)
Review Comment:
this method waits + asserts, which doesn't seem to be inline with the name `waitForSessionReady, please rename it accordingly
##########
tez-tests/src/test/java/org/apache/tez/mapreduce/TestMRRJobsDAGApi.java:
##########
@@ -400,16 +400,24 @@ public void testAMRelocalization() throws Exception {
additionalResources.put("test.jar", createLrObjFromPath(relocFilePath));
additionalResources.put("TezAppJar.jar", createLrObjFromPath(tezAppJarRemote));
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
finalState = testMRRSleepJobDagSubmitCore(true, false, false,
tezSession, true, MRInputAMSplitGeneratorRelocalizationTest.class, additionalResources);
assertEquals(DAGStatus.State.SUCCEEDED, finalState);
- assertEquals(TezAppMasterStatus.READY, tezSession.getAppMasterStatus());
+ waitForSessionReady(tezSession);
assertTrue(remoteFs.exists(new Path("/tmp/relocalizationfilefound")));
stopAndVerifyYarnApp(tezSession);
}
+ private void waitForSessionReady(TezClient tezSession)
+ throws IOException, TezException, InterruptedException {
+ boolean ready = tezSession.waitTillReady(60, TimeUnit.SECONDS);
Review Comment:
if we're talking about a short period between DAG succeed and session READY, isn't 60 seconds an overkill?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4736: Fix flaky TestMRRJobsDAGApi.testMultipleMRRSleepJobViaSession [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #521:
URL: https://github.com/apache/tez/pull/521#issuecomment-4969898215
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 8m 30s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 3s | | master passed |
| +1 :green_heart: | compile | 4m 0s | | master passed |
| +1 :green_heart: | checkstyle | 0m 32s | | master passed |
| +1 :green_heart: | javadoc | 0m 27s | | master passed |
| +0 :ok: | spotbugs | 0m 53s | | tez-tests in master has 6 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 59s | | the patch passed |
| +1 :green_heart: | codespell | 1m 47s | | No new issues. |
| +1 :green_heart: | compile | 3m 57s | | the patch passed |
| +1 :green_heart: | javac | 3m 57s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 27s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 26s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 3s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 71m 46s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 31s | | The patch does not generate ASF License warnings. |
| | | 105m 3s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-521/1/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux 56c37664b37c 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / 4bccf3a2339c913ade0bc5447bdfc505c5536128 |
| Default Java | Eclipse Adoptium-21.0.11+10-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-521/1/testReport/ |
| Max. process+thread count | 1483 (vs. ulimit of 5500) |
| modules | C: tez-tests U: tez-tests |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-521/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org