You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2018/08/08 15:01:19 UTC
[GitHub] nifi pull request #2941: [NIFI-5499] upgrade AngularJS to v1.7.2
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/2941
[NIFI-5499] upgrade AngularJS to v1.7.2
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi NIFI-5499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2941
----
commit c452cc4c1ba80b070bad2147439178cbb17b0e32
Author: Scott Aslan <sc...@...>
Date: 2018-08-08T15:00:21Z
[NIFI-5499] upgrade AngularJS to v1.7.2
----
---
[GitHub] nifi issue #2941: [NIFI-5499] upgrade AngularJS to v1.7.2
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2941
@scottyaslan I believe we also need to update the package-lock.json that is checked into source control. I noticed the package-lock.json is updated in the front end working directory.
---
[GitHub] nifi pull request #2941: [NIFI-5499] upgrade AngularJS to v1.7.2
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2941
---
[GitHub] nifi issue #2941: [NIFI-5499] upgrade AngularJS to v1.7.2
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2941
I have updated the package-lock.json file and added a commit to this PR. Nice catch @mcgilman!
---
[GitHub] nifi issue #2941: [NIFI-5499] upgrade AngularJS to v1.7.2
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2941
Will review...
---
[GitHub] nifi issue #2941: [NIFI-5499] upgrade AngularJS to v1.7.2
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2941
Thanks @scottyaslan! This has been merged to master.
---