You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/12/08 22:02:13 UTC

[jira] [Commented] (MAPREDUCE-6186) Minor: Remove multiple calls to requireJob() while displaying the conf page

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238460#comment-14238460 ] 

Hadoop QA commented on MAPREDUCE-6186:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12685842/MAPREDUCE-6186.patch
  against trunk revision 6c5bbd7.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5069//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5069//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5069//console

This message is automatically generated.

> Minor: Remove multiple calls to requireJob() while displaying the conf page
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6186
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6186
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>    Affects Versions: 2.6.0
>            Reporter: Rohit Agarwal
>            Assignee: Rohit Agarwal
>            Priority: Minor
>         Attachments: MAPREDUCE-6186.patch
>
>
> There are multiple calls to {{requireJob()}} in {{AppController.java#conf()}}
> The duplicate call seems to be introduced by mistake in https://github.com/apache/hadoop/commit/fe1cf3b0aca5f4d7a8af02a915b218f9b1de0fa6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)