You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/21 07:39:12 UTC
[GitHub] [flink] tinawenqiao opened a new pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
tinawenqiao opened a new pull request #16183:
URL: https://github.com/apache/flink/pull/16183
### What is the purpose of the change
Add execution checkpointing related configs in flink-conf.yaml. That may cause checkpoint failure according to the current configuration.
### Brief change log
Execution checkpointing configs such as execution.checkpointing.interval, execution.checkpointing.externalized-checkpoint-retention, execution.checkpointing.mode, etc are added in flink-conf.yaml.
### Verifying this change
This change is a trivial rework without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
### Documentation
Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 2d330008abcdeda947b13ae02c8d554f11ea1b75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062)
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 2d330008abcdeda947b13ae02c8d554f11ea1b75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062)
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199)
* 31aa5f56ac7ce65757e8f59a284eb4276c3a8154 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #16183:
URL: https://github.com/apache/flink/pull/16183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
}, {
"hash" : "7049a040094eb371f03626db308ce219ab698ded",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7049a040094eb371f03626db308ce219ab698ded",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 2d330008abcdeda947b13ae02c8d554f11ea1b75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062)
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199)
* 31aa5f56ac7ce65757e8f59a284eb4276c3a8154 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212)
* 7049a040094eb371f03626db308ce219ab698ded UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655205656
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
Actually, the default value of `500ms` you said really confused me, this option is a user-control value and have no default value. Where did you find the `500ms` configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao closed pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao closed pull request #16183:
URL: https://github.com/apache/flink/pull/16183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863098381
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6fb2031f66db4b60e3b7df127881449b84a5bd2b (Sat Aug 28 12:19:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655234078
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
This method is already deprecated, and `500ms` is really too quick for production users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655171989
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
500ms or 180s？In order to be consistent with the code, is it more appropriate to use 500ms？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
}, {
"hash" : "7049a040094eb371f03626db308ce219ab698ded",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216",
"triggerID" : "7049a040094eb371f03626db308ce219ab698ded",
"triggerType" : "PUSH"
}, {
"hash" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19221",
"triggerID" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 6fb2031f66db4b60e3b7df127881449b84a5bd2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19221)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655118982
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
From my point of view, user might uncomment this line for out-of-box usage. However, the value of `-1` is illegal and what I thought is like
~~~ bash
# The interval in which checkpoints are periodically scheduled.
#
# execution.checkpointing.interval: 3 min
~~~
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
From my point of view, user might uncomment this line for out-of-box usage. However, the value of `-1` is illegal and what I thought is like:
~~~ bash
# The interval in which checkpoints are periodically scheduled.
#
# execution.checkpointing.interval: 3 min
~~~
What do you think of this?
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
Actually, the default value of `500ms` you said really confused me, this option is a user-control value and have no default value. Where did you find the `500ms` configuration?
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
This method is already deprecated, and `500ms` is really too quick for production users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655246646
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
Yes, I also think it's too quick. I will change it to 3min.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao closed pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao closed pull request #16183:
URL: https://github.com/apache/flink/pull/16183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 2d330008abcdeda947b13ae02c8d554f11ea1b75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062)
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655215432
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
You can see it here [StreamExecutionEnvironment#enableCheckpointing](https://github.com/apache/flink/blob/60c7d9e77a6e9d82e0feb33f0d8bc263dddf2fd9/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java/#L518)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r654185324
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
In CheckpointConfig, checkpointInterval default value is -1. -1 means checkpoint is disabled. And I found that default value is 500ms in function enableCheckpointing(). I am confused which value is more reasonable.
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
+# execution.checkpointing.externalized-checkpoint-retention: [DELETE_ON_CANCELLATION, RETAIN_ON_CANCELLATION]
+# execution.checkpointing.max-concurrent-checkpoints: 1
+# execution.checkpointing.min-pause: 0
+# execution.checkpointing.mode: [EXACTLY_ONCE, AT_LEAST_ONCE]
+# execution.checkpointing.timeout: 600000
Review comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r654121018
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
+# execution.checkpointing.externalized-checkpoint-retention: [DELETE_ON_CANCELLATION, RETAIN_ON_CANCELLATION]
+# execution.checkpointing.max-concurrent-checkpoints: 1
+# execution.checkpointing.min-pause: 0
+# execution.checkpointing.mode: [EXACTLY_ONCE, AT_LEAST_ONCE]
+# execution.checkpointing.timeout: 600000
Review comment:
I think a more readable value `10 min` is better.
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
I think setting `execution.checkpointing.interval` as `-1` is illegal as minimal checkpoint time is 10ms. Maybe we could set it as `180 s` with some comments.
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
You could refer to [CheckpointConfig#setCheckpointInterval](https://github.com/apache/flink/blob/60c7d9e77a6e9d82e0feb33f0d8bc263dddf2fd9/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java#L219-L227) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-864803680
interval is set to 500ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655171989
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
500ms or 3min？In order to be consistent with the code, is it more appropriate to use 500ms？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-864803680
interval is set to 500ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
}, {
"hash" : "7049a040094eb371f03626db308ce219ab698ded",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216",
"triggerID" : "7049a040094eb371f03626db308ce219ab698ded",
"triggerType" : "PUSH"
}, {
"hash" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19221",
"triggerID" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199)
* 31aa5f56ac7ce65757e8f59a284eb4276c3a8154 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212)
* 7049a040094eb371f03626db308ce219ab698ded Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216)
* 6fb2031f66db4b60e3b7df127881449b84a5bd2b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19221)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655118982
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
From my point of view, user might uncomment this line for out-of-box usage. However, the value of `-1` is illegal and what I thought is like
~~~ bash
# The interval in which checkpoints are periodically scheduled.
#
# execution.checkpointing.interval: 3 min
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863723839
> @tinawenqiao As I said in #16147, please modify your description of this PR, it's not recommended to leave the description as the default template.
The pr description has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
}, {
"hash" : "7049a040094eb371f03626db308ce219ab698ded",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216",
"triggerID" : "7049a040094eb371f03626db308ce219ab698ded",
"triggerType" : "PUSH"
}, {
"hash" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19221",
"triggerID" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 31aa5f56ac7ce65757e8f59a284eb4276c3a8154 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212)
* 7049a040094eb371f03626db308ce219ab698ded Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216)
* 6fb2031f66db4b60e3b7df127881449b84a5bd2b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19221)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
}, {
"hash" : "7049a040094eb371f03626db308ce219ab698ded",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216",
"triggerID" : "7049a040094eb371f03626db308ce219ab698ded",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 2d330008abcdeda947b13ae02c8d554f11ea1b75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062)
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199)
* 31aa5f56ac7ce65757e8f59a284eb4276c3a8154 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212)
* 7049a040094eb371f03626db308ce219ab698ded Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #16183:
URL: https://github.com/apache/flink/pull/16183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tinawenqiao commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
tinawenqiao commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655171989
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
500ms or 180s？In order to be consistent with the code, is it more appropriate to use 500ms？
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
500ms or 3min？In order to be consistent with the code, is it more appropriate to use 500ms？
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
You can see it here [StreamExecutionEnvironment#enableCheckpointing](https://github.com/apache/flink/blob/60c7d9e77a6e9d82e0feb33f0d8bc263dddf2fd9/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java/#L518)
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
Yes, I also think it's too quick. I will change it to 3min.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #16183:
URL: https://github.com/apache/flink/pull/16183#discussion_r655118982
##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -107,7 +107,18 @@ parallelism.default: 1
#==============================================================================
# The backend that will be used to store operator state checkpoints if
-# checkpointing is enabled.
+# checkpointing is enabled. Checkpointing is enabled when execution.checkpointing.interval > 0.
+#
+# Execution checkpointing related parameters.
+#
+# execution.checkpointing.interval: -1
Review comment:
From my point of view, user might uncomment this line for out-of-box usage. However, the value of `-1` is illegal and what I thought is like:
~~~ bash
# The interval in which checkpoints are periodically scheduled.
#
# execution.checkpointing.interval: 3 min
~~~
What do you think of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
}, {
"hash" : "7049a040094eb371f03626db308ce219ab698ded",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216",
"triggerID" : "7049a040094eb371f03626db308ce219ab698ded",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199)
* 31aa5f56ac7ce65757e8f59a284eb4276c3a8154 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212)
* 7049a040094eb371f03626db308ce219ab698ded Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16183: [FLINK-22974][dist] Add execution checkpointing related configs in flink-conf.yaml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16183:
URL: https://github.com/apache/flink/pull/16183#issuecomment-863123195
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "259efc990b8d450f8d012e89731b27f88fd3cb16",
"triggerType" : "PUSH"
}, {
"hash" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19062",
"triggerID" : "2d330008abcdeda947b13ae02c8d554f11ea1b75",
"triggerType" : "PUSH"
}, {
"hash" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199",
"triggerID" : "26e53475b8e3ed2c7cf2e4d855214cb0f93919bb",
"triggerType" : "PUSH"
}, {
"hash" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212",
"triggerID" : "31aa5f56ac7ce65757e8f59a284eb4276c3a8154",
"triggerType" : "PUSH"
}, {
"hash" : "7049a040094eb371f03626db308ce219ab698ded",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216",
"triggerID" : "7049a040094eb371f03626db308ce219ab698ded",
"triggerType" : "PUSH"
}, {
"hash" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6fb2031f66db4b60e3b7df127881449b84a5bd2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 259efc990b8d450f8d012e89731b27f88fd3cb16 UNKNOWN
* 26e53475b8e3ed2c7cf2e4d855214cb0f93919bb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19199)
* 31aa5f56ac7ce65757e8f59a284eb4276c3a8154 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19212)
* 7049a040094eb371f03626db308ce219ab698ded Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19216)
* 6fb2031f66db4b60e3b7df127881449b84a5bd2b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org