You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/09/24 21:05:15 UTC

[GitHub] [commons-statistics] aherbert commented on pull request #37: Remove redundant variable.

aherbert commented on PR #37:
URL: https://github.com/apache/commons-statistics/pull/37#issuecomment-1257065200

   The code is meant to be self-documenting. A Nakagami distribution is parameterised by mu and omega; the gamma distribution by shape and scale. You can sample from a Nakagami using a Gamma. Removing the variable does not enhance the code and will not change efficiency. Any caller who requires a sampler will be spending negligible time constructing a sampler and all the time using it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org