You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2020/05/21 19:17:02 UTC
[Impala-ASF-CR] IMPALA-9772: [DOCS] replace mem limit texts with revised contents
Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15973
Change subject: IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
......................................................................
IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
explained what will happen if the query process exceeds the mem limit
changed the error message for the last query
also added reference to admission control
Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
---
M docs/topics/impala_mem_limit.xml
1 file changed, 55 insertions(+), 73 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/15973/1
--
To view, visit http://gerrit.cloudera.org:8080/15973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
Gerrit-Change-Number: 15973
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9772: [DOCS] replace mem limit texts with revised contents
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15973 )
Change subject: IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
Gerrit-Change-Number: 15973
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 20:06:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9772: [DOCS] replace mem limit texts with revised contents
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15973 )
Change subject: IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
......................................................................
Patch Set 1:
Bikram, can you review this one? I was involved in drafting and it would be good to get a fresh pair of eyes.
--
To view, visit http://gerrit.cloudera.org:8080/15973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
Gerrit-Change-Number: 15973
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 16:34:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9772: [DOCS] replace mem limit texts with revised contents
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15973 )
Change subject: IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
......................................................................
IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
explained what will happen if the query process exceeds the mem limit
changed the error message for the last query
also added reference to admission control
Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
Reviewed-on: http://gerrit.cloudera.org:8080/15973
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
---
M docs/topics/impala_mem_limit.xml
1 file changed, 55 insertions(+), 73 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Bikramjeet Vig: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
Gerrit-Change-Number: 15973
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9772: [DOCS] replace mem limit texts with revised contents
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15973 )
Change subject: IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/597/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
Gerrit-Change-Number: 15973
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2020 19:17:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9772: [DOCS] replace mem limit texts with revised contents
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15973 )
Change subject: IMPALA-9772: [DOCS] replace mem_limit texts with revised contents
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/597/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7042b0d66c376e3179fb425109f9103710a25c49
Gerrit-Change-Number: 15973
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 May 2020 19:36:36 +0000
Gerrit-HasComments: No