[jira] [Commented] (CLOUDSTACK-9597) Incorrect updateResourceCount()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666662#comment-15666662 ] 

ASF GitHub Bot commented on CLOUDSTACK-9597:
--------------------------------------------

Github user marcaurele commented on the issue:

    https://github.com/apache/cloudstack/pull/1764
  
    Will fix the checks in `ConfigurationServerImpl`:
    - https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/server/ConfigurationServerImpl.java#L1426
    - https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/server/ConfigurationServerImpl.java#L1455


> Incorrect updateResourceCount()
> -------------------------------
>
>                 Key: CLOUDSTACK-9597
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9597
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
>
> h3. Currently
> On management server startup, the {{ConfigurationServerImpl}} does a check on the resource type * resource count versus number of accounts & domains to see if all accounts and domains have a resource count set for each resource type. The list of accounts and domains are fetched excluding the removed ones. But the number of resourceCount by account and domain takes all of them, leading to an incorrect math check.
> The API command {{updateResourceCount}} can crash with an incorrect SQL query.
> I discovered the problem while adding a new {{ResourceType}}.
> h3. Changes
> Fetch the number of resourceCount by domain and account excluding the removed ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)