You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/02 18:50:50 UTC

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #754: GEODE-8949: Versioning improvements

pivotal-jbarrett commented on a change in pull request #754:
URL: https://github.com/apache/geode-native/pull/754#discussion_r585822577



##########
File path: ci/lib/templates.lib.txt
##########
@@ -90,7 +90,7 @@ run-clang-tidy -j $(nproc) -quiet
 
 (@ def clang_format_bash_task(): -@)
 set -ueo pipefail
-export GEODE_HOME=$(pwd)/geode/expanded/apache-geode-$(cat geode/version)
+export GEODE_HOME=$(pwd)/geode

Review comment:
       Sort of out of scope for this PR. I agree making them consistent would be nice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org