[jira] [Commented] (CASSANDRA-12283) CommitLogSegmentManagerTest.testCompressedCommitLogBackpressure is flaky

["Benjamin Lerer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407705#comment-15407705 ] 

Benjamin Lerer commented on CASSANDRA-12283:
--------------------------------------------

I could not reproduce the problem on my machine.
While looking at the code I discovered 2 potential issues in {{Util.spinAssertEquals}}.
# In {{3.0}} and {{2.2}} the loop will not run for the correct amount of time: https://github.com/apache/cassandra/blob/cassandra-3.0/test/unit/org/apache/cassandra/Util.java#L525
# the use of {{Thread.yield()}} is surprising to me as the amount of time it will take is unpredictable.

My current suggestion is to fix {{Util.spinAssertEquals}} by fixing the loop and removing the {{Thread.yield()}} call and see if it solves the problem.

[~JoshuaMcKenzie] What do you think?


> CommitLogSegmentManagerTest.testCompressedCommitLogBackpressure is flaky
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12283
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12283
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Joshua McKenzie
>            Assignee: Benjamin Lerer
>            Priority: Minor
>              Labels: unittest
>
> Failed 3 of the last 38 runs.
> [Failure|http://cassci.datastax.com/job/cassandra-3.9_testall/lastCompletedBuild/testReport/org.apache.cassandra.db.commitlog/CommitLogSegmentManagerTest/testCompressedCommitLogBackpressure/]
> Details:
> Error Message
> Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
> Stacktrace
> junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
> 	at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)