You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/09 16:50:43 UTC

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #740: feat: convert uri to uris

LiteSun commented on a change in pull request #740:
URL: https://github.com/apache/apisix-dashboard/pull/740#discussion_r519962326



##########
File path: web/src/pages/Route/List.tsx
##########
@@ -35,24 +35,28 @@ const Page: React.FC = () => {
     },
     {
       title: formatMessage({ id: 'page.route.domainName' }),
-      dataIndex: 'hosts',
       hideInSearch: true,
-      render: (_, record) =>
-        (record.hosts || []).map((host) => (
-          <Tag key={host} color="geekblue">
-            {host}
+      render: (_, record) => {
+        const list = record.hosts || (record.host && [record.host]) || [];

Review comment:
       just want to confirm: Is it possible to return both hosts and hosts with different values?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org