You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/06/07 12:43:17 UTC

[GitHub] rafaelweingartner commented on a change in pull request #2681: Issue 2680: Source NAT option on Private Gateway

rafaelweingartner commented on a change in pull request #2681: Issue 2680: Source NAT option on Private Gateway
URL: https://github.com/apache/cloudstack/pull/2681#discussion_r193731500
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##########
 @@ -477,8 +477,8 @@ def fw_vpcrouter(self):
                             ("eth1", "eth1", guestNetworkCidr)])
 
             self.fw.append(["nat", "front",
-                            "-A POSTROUTING -s %s -o %s -j SNAT --to-source %s" %
-                            (guestNetworkCidr, self.dev, self.address['public_ip'])])
+                            "-A POSTROUTING -o %s -j SNAT --to-source %s" %
+                            (self.dev, self.address['public_ip'])])
 
 Review comment:
   I think it might be safer to use @rhtyd suggestion. What do you guys think about it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services