[GitHub] [beam] robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #10621: [BEAM-9056] Staging artifacts from environment
URL: https://github.com/apache/beam/pull/10621#discussion_r389114214
 
 

 ##########
 File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
 ##########
 @@ -261,14 +263,20 @@ public String registerCoder(Coder<?> coder) throws IOException {
    * return the same unique ID.
    */
   public String registerEnvironment(Environment env) {
+    String environmentId;
     String existing = environmentIds.get(env);
     if (existing != null) {
-      return existing;
+      environmentId = existing;
+    } else {
+      String name = uniqify(env.getUrn(), environmentIds.values());
+      environmentIds.put(env, name);
+      componentsBuilder.putEnvironments(name, env);
+      environmentId = name;
     }
-    String name = uniqify(env.getUrn(), environmentIds.values());
-    environmentIds.put(env, name);
-    componentsBuilder.putEnvironments(name, env);
-    return name;
+    if (defaultEnvironmentId == null) {
 
 Review comment:
   This is a case where doing it in a different commit in the same PR could make sense. But I'm OK with deferring as long as it happens soon. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services