You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/24 15:05:56 UTC

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6919: Minor console access refactor and improvements

nvazquez commented on code in PR #6919:
URL: https://github.com/apache/cloudstack/pull/6919#discussion_r1031613299


##########
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##########
@@ -207,15 +199,22 @@ private ConsoleEndpoint generateAccessEndpoint(Long vmId, String sessionUuid, St
             throw new CloudRuntimeException(msg);
         }
 
+        String vmUuid = vm.getUuid();
+        if (vm.getState() != VirtualMachine.State.Running) {

Review Comment:
   For Running it is, do you think Starting, Stopping and Migrating should be required as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org