You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by conkeyn <gi...@git.apache.org> on 2015/09/07 04:01:49 UTC

[GitHub] storm pull request: 修改jdbcClient

GitHub user conkeyn opened a pull request:

    https://github.com/apache/storm/pull/724

    修改jdbcClient

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/conkeyn/storm feature-zk-custorm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #724
    
----
commit c19ff6a907c389ae539ab2dc721c048f29c99171
Author: "zhonqqing.lin@zkteco.com" <"z...@notebook-lzq>
Date:   2015-09-07T01:58:32Z

    修改jdbcClient

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: 修改jdbcClient

Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:

    https://github.com/apache/storm/pull/724#issuecomment-167940068
  
    @d2r @Parth-Brahmbhatt  Since the PR is no longer updated, I think we can close it now. @conkeyn can create a new PR if necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: 修改jdbcClient

Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/724#issuecomment-167625458
  
    @conkeyn,
    
    Could you change commit messages to English, create a Jira issue for this pull request, and fix the conflicts with the master branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: 修改jdbcClient

Posted by Renkai <gi...@git.apache.org>.
Github user Renkai commented on the pull request:

    https://github.com/apache/storm/pull/724#issuecomment-138547486
  
    You'd better use English and contribute by this guide
    http://storm.apache.org/documentation/Contributing-to-Storm.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: 修改jdbcClient

Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:

    https://github.com/apache/storm/pull/724#issuecomment-167639763
  
    What jira is this associated with? I see some ip addresses in pom and even looking at the change I cant understand what is this intending to do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #724: ������jdbcClient

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/724


---