You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/22 07:19:09 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #12497: Support installing providers with no dependencies via extras

potiuk commented on a change in pull request #12497:
URL: https://github.com/apache/airflow/pull/12497#discussion_r528293774



##########
File path: scripts/ci/pre_commit/pre_commit_check_setup_extra_packages_ref.py
##########
@@ -53,13 +53,16 @@ def get_extras_from_setup() -> Dict[str, List[str]]:
     extras_section = extras_section_regex.findall(setup_content)[0]
 
     extras_regex = re.compile(
-        rf'^\s+[\"\']({PY_IDENTIFIER})[\"\']:\s*({PY_IDENTIFIER})[^#\n]*(#\s*TODO.*)?$', re.MULTILINE
+        rf'^\s+[\"\']({PY_IDENTIFIER})[\"\']:\s*({PY_IDENTIFIER}|\[\])[^#\n]*(#\s*TODO.*)?$', re.MULTILINE

Review comment:
       Agree. If we refactor the setup.py, we should mirror the structure of the setup.py and docs - this way it will be easier as rather than base it on comments we can simply have separate group of those aliases..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org