You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/09/05 02:04:45 UTC
[PR] chore(docker): speed up image builds and the compose dev loop [superset]
sadpandajoe opened a new pull request, #43916:
URL: https://github.com/apache/superset/pull/43916
### SUMMARY
Speeds up Docker image builds and the `docker compose` dev loop with no behavior changes to the running application:
- Restructures the Dockerfile's `lean`/`dev` stages so Python dependencies install before `COPY superset superset`, so the pip/uv layer stays cached across ordinary source-code edits instead of reinstalling on every change.
- Folds the `dev` stage's previously uncached `uv pip install .[postgres]` into the same cached editable-install step, and drops the `compileall` pass from `dev` (kept in `lean`, which is what `ci`/`showtime` build from) since it only slows down local iteration without benefiting dev containers.
- Guards `docker/docker-bootstrap.sh`'s per-container-start `uv pip install -e ...` reinstalls (superset-core, the app, and the postgres extra) behind a hash of `pyproject.toml` + `requirements/*.txt` (+ `superset-core/pyproject.toml`), stored in a marker inside the venv, so unchanged dependencies are skipped on restart instead of reinstalled every time.
- Guards `docker/docker-frontend.sh`'s unconditional `npm install` behind a hash of `package.json`/`package-lock.json` stored in a `node_modules` marker, skipping it when unchanged; adds a `FORCE_NPM_INSTALL` override to opt back into always installing.
- Defaults `DISABLE_TS_CHECKER` to `true` for the `superset-node` service in `docker-compose.yml`, matching `docker-compose-light.yml`, so webpack skips its TypeScript type-checking pass (and the several GB of memory it uses) in dev by default.
- Skips the full `superset load_examples` reload in `docker/docker-init.sh` on repeat `docker compose up` runs against the same `superset_home` volume once a marker file confirms examples have already loaded, refreshing metadata only instead. Adds `SUPERSET_FORCE_LOAD_EXAMPLES` to force a full reload (e.g. after changing example datasets, or after wiping the database volume while keeping `superset_home`). Cypress runs always take the full-load path since they populate a separate test database.
- Updates `docs/admin_docs/installation/docker-compose.mdx`, `docs/developer_docs/contributing/development-setup.md`, `docker/.env`, and `UPDATING.md` to document the new env vars and default-behavior changes.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (build/tooling change, no UI changes)
### TESTING INSTRUCTIONS
- `bash -n` on every edited shell script (`docker/docker-bootstrap.sh`, `docker/docker-frontend.sh`, `docker/docker-init.sh`) passes.
- `docker compose -f docker-compose.yml config -q` and `docker compose -f docker-compose-light.yml config -q` both pass.
- `docker build --target dev -t superset-dev-loop-test .` and `docker build --target lean -t superset-lean-loop-test .` both build successfully end-to-end.
- Smoke-tested both resulting images: `python -c "import superset"`, `uv pip show apache-superset` (confirms `Editable project location: /app`), and `superset --help` all run correctly in both the `dev` and `lean` images.
- To manually verify the dev-loop speedups: run `docker compose up --build` once to populate caches/markers, then `docker compose up` again โ `docker-bootstrap.sh` should skip the editable reinstalls, `docker-frontend.sh` should skip `npm install`, and `docker-init.sh` should skip the full `load_examples` run (metadata-only instead).
- `pre-commit run` passes clean on the changed files.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
๐ค Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5548647980
### <span aria-hidden="true">โ
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">๐จ</span> Latest commit | 07a675480d9484e5f853f08061289489445e6d31 |
|<span aria-hidden="true">๐</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a9b78d59d8fc20008ad5d7c |
|<span aria-hidden="true">๐</span> Deploy Preview | [https://deploy-preview-43916--superset-docs-preview.netlify.app](https://deploy-preview-43916--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">๐ฑ</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">๐ค</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLCoAwDAXAu2RtsQhq9QYeo-ZFBD8J9QMi3t3uZjEvWdLNTuqJChpT3HnO5lmTlFBeJDnI7VZVc4eJ4LIcIbbqMyDXJnZjG1B3CBNX3vsQUaNl-n4) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43916--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5549548542
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5589499454
I'm cool with all steps but thinks these changes below are a bit overkill and complicates build logic. We have Dependabot PRs merged pretty often so the benefits would be somehow scuffled and `npm` does its job pretty fine to calculate dep graph's hash, we kinda don't have to roll out our own.
```
- Guards docker/docker-bootstrap.sh's per-container-start uv pip install -e ... reinstalls (superset-core, the app, and the postgres extra) behind a hash of pyproject.toml + requirements/*.txt (+ superset-core/pyproject.toml), stored in a marker inside the venv, so unchanged dependencies are skipped on restart instead of reinstalled every time.
- Guards docker/docker-frontend.sh's unconditional npm install behind a hash of package.json/package-lock.json stored in a node_modules marker, skipping it when unchanged; adds a FORCE_NPM_INSTALL override to opt back into always installing.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43916:
URL: https://github.com/apache/superset/pull/43916#discussion_r3939099086
##########
docker/docker-init.sh:
##########
@@ -70,12 +70,28 @@ if [ "$SUPERSET_LOAD_EXAMPLES" = "yes" ]; then
# Load some data to play with
echo_step "4" "Starting" "Loading examples"
+ EXAMPLES_LOADED_MARKER="${SUPERSET_HOME}/.examples-loaded"
- # If Cypress run which consumes superset_test_config โ load required data for tests
- if [ "$CYPRESS_CONFIG" == "true" ]; then
- superset load_examples --load-test-data
+ # Loading examples parses and inserts every example dataset/dashboard/chart
+ # and is one of the slowest steps of `docker compose up`. Once it has
+ # succeeded, subsequent `docker-init.sh` runs against the same
+ # superset_home volume only need to refresh metadata (e.g. after a
+ # `superset db upgrade`), not reload the data itself. Set
+ # SUPERSET_FORCE_LOAD_EXAMPLES=yes to force a full reload regardless.
+ # Cypress runs always do a full reload since they load a distinct set of
+ # test data (`--load-test-data`) into a separate `superset_cypress`
+ # database that the metadata-only marker doesn't track.
+ if [ -f "$EXAMPLES_LOADED_MARKER" ] && [ "$SUPERSET_FORCE_LOAD_EXAMPLES" != "yes" ] && [ "$CYPRESS_CONFIG" != "true" ]; then
Review Comment:
**Suggestion:** When the database volume is recreated but `superset_home` remains, this marker selects metadata-only loading and leaves the database without example data. [possible bug]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f5723ccade554b7c81700733b02d778d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f5723ccade554b7c81700733b02d778d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docker/docker-init.sh
**Line:** 84:84
**Comment:**
*Possible Bug: When the database volume is recreated but `superset_home` remains, this marker selects metadata-only loading and leaves the database without example data.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43916&comment_hash=7fff8926a4f17ac6d03bf87447ddaf5acd537ce82b96c91ea0f5136cb05a18ae&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43916&comment_hash=7fff8926a4f17ac6d03bf87447ddaf5acd537ce82b96c91ea0f5136cb05a18ae&reaction=dislike'>๐</a>
##########
docker/docker-init.sh:
##########
@@ -70,12 +70,28 @@ if [ "$SUPERSET_LOAD_EXAMPLES" = "yes" ]; then
# Load some data to play with
echo_step "4" "Starting" "Loading examples"
+ EXAMPLES_LOADED_MARKER="${SUPERSET_HOME}/.examples-loaded"
- # If Cypress run which consumes superset_test_config โ load required data for tests
- if [ "$CYPRESS_CONFIG" == "true" ]; then
- superset load_examples --load-test-data
+ # Loading examples parses and inserts every example dataset/dashboard/chart
+ # and is one of the slowest steps of `docker compose up`. Once it has
+ # succeeded, subsequent `docker-init.sh` runs against the same
+ # superset_home volume only need to refresh metadata (e.g. after a
+ # `superset db upgrade`), not reload the data itself. Set
+ # SUPERSET_FORCE_LOAD_EXAMPLES=yes to force a full reload regardless.
+ # Cypress runs always do a full reload since they load a distinct set of
+ # test data (`--load-test-data`) into a separate `superset_cypress`
+ # database that the metadata-only marker doesn't track.
+ if [ -f "$EXAMPLES_LOADED_MARKER" ] && [ "$SUPERSET_FORCE_LOAD_EXAMPLES" != "yes" ] && [ "$CYPRESS_CONFIG" != "true" ]; then
+ echo "Examples already loaded, refreshing metadata only (set SUPERSET_FORCE_LOAD_EXAMPLES=yes to force a full reload)"
+ superset load_examples --only-metadata
else
- superset load_examples
+ # If Cypress run which consumes superset_test_config โ load required data for tests
+ if [ "$CYPRESS_CONFIG" == "true" ]; then
+ superset load_examples --load-test-data
+ else
+ superset load_examples
+ fi
+ touch "$EXAMPLES_LOADED_MARKER"
Review Comment:
**Suggestion:** The marker is created after a successful command even when individual dataset loaders only log failures, so later starts stop retrying those failed loads. [logic error]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=09204ae121064941bb4ad9db81a1a8e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=09204ae121064941bb4ad9db81a1a8e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docker/docker-init.sh
**Line:** 94:94
**Comment:**
*Logic Error: The marker is created after a successful command even when individual dataset loaders only log failures, so later starts stop retrying those failed loads.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43916&comment_hash=10f780f18a2f97658058742e091f112d5b9c14e8e6c564b42a202b73d41a6d75&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43916&comment_hash=10f780f18a2f97658058742e091f112d5b9c14e8e6c564b42a202b73d41a6d75&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #43916:
URL: https://github.com/apache/superset/pull/43916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5548630216
<!-- Bito Reply -->
The flagged issue regarding `SUPERSET_FORCE_LOAD_EXAMPLES` is correct. In the current Docker Compose configuration, environment variables defined in the shell are not automatically passed to the `superset-init` container unless explicitly mapped in the `docker-compose.yml` file. To resolve this, you should add `SUPERSET_FORCE_LOAD_EXAMPLES` to the `environment` section of the `superset-init` service in your `docker-compose.yml` file, allowing it to inherit the value from your shell environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43916:
URL: https://github.com/apache/superset/pull/43916#discussion_r3940658832
##########
docs/admin_docs/installation/docker-compose.mdx:
##########
@@ -196,7 +196,10 @@ One important variable is `SUPERSET_LOAD_EXAMPLES` which determines whether the
container will populate example data and visualizations into the metadata database. These examples
are helpful for learning and testing out Superset but unnecessary for experienced users and
production deployments. The loading process can sometimes take a few minutes and a good amount of
-CPU, so you may want to disable it on a resource-constrained device.
+CPU, so you may want to disable it on a resource-constrained device. Once examples have been loaded
+successfully, later `superset_init` runs against the same `superset_home` volume only refresh
+example metadata rather than reloading the data; set `SUPERSET_FORCE_LOAD_EXAMPLES=yes` to force a
+full reload.
Review Comment:
Good catch. `SUPERSET_FORCE_LOAD_EXAMPLES` is now mapped into the `superset-init` / `superset-init-light` environment in both compose files, so setting it from the shell reaches the init script. _๐ค Addressed by [Claude Code](https://claude.com/claude-code)_
##########
docker/docker-init.sh:
##########
@@ -70,12 +70,28 @@ if [ "$SUPERSET_LOAD_EXAMPLES" = "yes" ]; then
# Load some data to play with
echo_step "4" "Starting" "Loading examples"
+ EXAMPLES_LOADED_MARKER="${SUPERSET_HOME}/.examples-loaded"
- # If Cypress run which consumes superset_test_config โ load required data for tests
- if [ "$CYPRESS_CONFIG" == "true" ]; then
- superset load_examples --load-test-data
+ # Loading examples parses and inserts every example dataset/dashboard/chart
+ # and is one of the slowest steps of `docker compose up`. Once it has
+ # succeeded, subsequent `docker-init.sh` runs against the same
+ # superset_home volume only need to refresh metadata (e.g. after a
+ # `superset db upgrade`), not reload the data itself. Set
+ # SUPERSET_FORCE_LOAD_EXAMPLES=yes to force a full reload regardless.
+ # Cypress runs always do a full reload since they load a distinct set of
+ # test data (`--load-test-data`) into a separate `superset_cypress`
+ # database that the metadata-only marker doesn't track.
+ if [ -f "$EXAMPLES_LOADED_MARKER" ] && [ "$SUPERSET_FORCE_LOAD_EXAMPLES" != "yes" ] && [ "$CYPRESS_CONFIG" != "true" ]; then
Review Comment:
Agreed. The marker file is gone; the script now asks the databases directly (example table present in the examples DB and the `world_health` dashboard present in the metadata DB) and only skips the load when both exist, so a recreated database volume triggers a full reload. _๐ค Addressed by [Claude Code](https://claude.com/claude-code)_
##########
docker/docker-init.sh:
##########
@@ -70,12 +70,28 @@ if [ "$SUPERSET_LOAD_EXAMPLES" = "yes" ]; then
# Load some data to play with
echo_step "4" "Starting" "Loading examples"
+ EXAMPLES_LOADED_MARKER="${SUPERSET_HOME}/.examples-loaded"
- # If Cypress run which consumes superset_test_config โ load required data for tests
- if [ "$CYPRESS_CONFIG" == "true" ]; then
- superset load_examples --load-test-data
+ # Loading examples parses and inserts every example dataset/dashboard/chart
+ # and is one of the slowest steps of `docker compose up`. Once it has
+ # succeeded, subsequent `docker-init.sh` runs against the same
+ # superset_home volume only need to refresh metadata (e.g. after a
+ # `superset db upgrade`), not reload the data itself. Set
+ # SUPERSET_FORCE_LOAD_EXAMPLES=yes to force a full reload regardless.
+ # Cypress runs always do a full reload since they load a distinct set of
+ # test data (`--load-test-data`) into a separate `superset_cypress`
+ # database that the metadata-only marker doesn't track.
+ if [ -f "$EXAMPLES_LOADED_MARKER" ] && [ "$SUPERSET_FORCE_LOAD_EXAMPLES" != "yes" ] && [ "$CYPRESS_CONFIG" != "true" ]; then
+ echo "Examples already loaded, refreshing metadata only (set SUPERSET_FORCE_LOAD_EXAMPLES=yes to force a full reload)"
+ superset load_examples --only-metadata
else
- superset load_examples
+ # If Cypress run which consumes superset_test_config โ load required data for tests
+ if [ "$CYPRESS_CONFIG" == "true" ]; then
+ superset load_examples --load-test-data
+ else
+ superset load_examples
+ fi
+ touch "$EXAMPLES_LOADED_MARKER"
Review Comment:
The marker file is replaced by an in-DB check, so there is no longer a flag written after a partially failed run. The check itself is also treated as best-effort: any error falls through to a full load, and `SUPERSET_FORCE_LOAD_EXAMPLES=yes` remains available to retry a partial load. _๐ค Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5589548392
Fair point, dropped both hash guards in e62950269d: `docker-bootstrap.sh` and `docker-frontend.sh` are back to master, so the PR is now just the Dockerfile layer reordering, the examples skip in `docker-init.sh`, and the `DISABLE_TS_CHECKER` default.
_๐ค Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5594769890
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43916:
URL: https://github.com/apache/superset/pull/43916#discussion_r3939096031
##########
docs/admin_docs/installation/docker-compose.mdx:
##########
@@ -196,7 +196,10 @@ One important variable is `SUPERSET_LOAD_EXAMPLES` which determines whether the
container will populate example data and visualizations into the metadata database. These examples
are helpful for learning and testing out Superset but unnecessary for experienced users and
production deployments. The loading process can sometimes take a few minutes and a good amount of
-CPU, so you may want to disable it on a resource-constrained device.
+CPU, so you may want to disable it on a resource-constrained device. Once examples have been loaded
+successfully, later `superset_init` runs against the same `superset_home` volume only refresh
+example metadata rather than reloading the data; set `SUPERSET_FORCE_LOAD_EXAMPLES=yes` to force a
+full reload.
Review Comment:
**Suggestion:** The documented `SUPERSET_FORCE_LOAD_EXAMPLES` override is not passed into `superset-init` by Compose, so setting it from the shell does not force a reload. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d1286c74c2a54f52939ce976d7797884&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d1286c74c2a54f52939ce976d7797884&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/admin_docs/installation/docker-compose.mdx
**Line:** 199:202
**Comment:**
*Api Mismatch: The documented `SUPERSET_FORCE_LOAD_EXAMPLES` override is not passed into `superset-init` by Compose, so setting it from the shell does not force a reload.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43916&comment_hash=8662e3b612f55fcd9f9bf506fe4a88bd59142d21dcfd6c2de147dfca4ca8194f&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43916&comment_hash=8662e3b612f55fcd9f9bf506fe4a88bd59142d21dcfd6c2de147dfca4ca8194f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5548628988
### <span aria-hidden="true">โ
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">๐จ</span> Latest commit | 70a8dcefb9126699cd2ddf1ab4d9be5ed0cebba1 |
|<span aria-hidden="true">๐</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a9b78bdd993600008b0ccad |
|<span aria-hidden="true">๐</span> Deploy Preview | [https://deploy-preview-43916--superset-docs-preview.netlify.app](https://deploy-preview-43916--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">๐ฑ</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">๐ค</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLCoAwDADRu2RtsSBo6w08RpsEClYT6gdEvLuZ1SzeC9pk0xNmgA5ySzsWeyzSuCfBlZsjvl0VUXcoM11qkFirPAsZHVPMU8hEMQ6jt0L2iIng-wE) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43916--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(docker): speed up image builds and the compose dev loop [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43916:
URL: https://github.com/apache/superset/pull/43916#issuecomment-5548617529
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org