[GitHub] [maven] hboutemy commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution

[GitBox <gi...@apache.org>]

hboutemy commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution
URL: https://github.com/apache/maven/pull/297#discussion_r339336793
 
 

 ##########
 File path: apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
 ##########
 @@ -22,21 +22,18 @@ Apache Maven includes a number of components and libraries with separate
 copyright notices and license terms. Your use of those components are 
 subject to the terms and conditions of the following licenses: 
 ##
-#set ( $apacheLicenseNames = [ "Apache License, Version 2.0", "The Apache Software License, Version 2.0",
-    "ASLv2", "Apache Public License 2.0", "Apache 2.0" ] )
+#set ( $apacheMavenGroupIds = [ "org.apache.maven", "org.apache.maven.wagon", "org.apache.maven.resolver",
+                                "org.apache.maven.shared" ] )
 #set ( $MITLicenseNames = [ "MIT License", "MIT license", "The MIT License" ] )
 #foreach ( $project in $projects )
 #**##foreach ( $license in $project.licenses)
-#*  *##if ( !$apacheLicenseNames.contains( $license.name ) )
+#*  *##set ( $groupId = $project.artifact.groupId )
+#*  *##if ( !$apacheMavenGroupIds.contains( $groupId ) )
 #*    *##set ( $artId = $project.artifact.artifactId )
 #*    *##set ( $url = $license.url )
 #*    *##set ( $spdx = false )
 #*    *##set ( $includeLicense = true )
 #*    *###
-#*    *##if ( $project.artifact.artifactId == "jcl-over-slf4j" )
 
 Review comment:
   everything already done: license in pom.xml was not consistent with license in scm
   see https://issues.apache.org/jira/browse/MNG-6779 and the associated PR to slf4j that has already been merged

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services