[GitHub] [flink] zhijiangW edited a comment on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

[GitBox <gi...@apache.org>]

zhijiangW edited a comment on issue #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#issuecomment-483689380
 
 
   Thanks for reviews and concerns @zentol .
   
   I checked the previous usages of `IOMetrics#getNumBytesInRemote` and `IOMetrics#getNumBytesInLocal`, it seems that all the usages are merging these metrics together in handlers, so the framework does not provide the way for showing them separately ATM. Otherwise the users extend the handler to fetch separate metrics, but if in this case should we confirm the compatibility as before?
   
   In flink framework we have not changed any behaviors as before, not functional loss. But we should not be responsible for the private version which is maintained by outside users. Or I missed anything usages atm?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services