You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/18 02:50:26 UTC

[GitHub] [kafka] rondagostino commented on a change in pull request #10113: MINOR: Add KIP-500 BrokerServer and ControllerServer

rondagostino commented on a change in pull request #10113:
URL: https://github.com/apache/kafka/pull/10113#discussion_r578090610



##########
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##########
@@ -70,7 +70,8 @@ object AlterIsrManager {
     time: Time,
     metrics: Metrics,
     threadNamePrefix: Option[String],
-    brokerEpochSupplier: () => Long
+    brokerEpochSupplier: () => Long,
+    brokerId: Int

Review comment:
       This supplies the broker epoch rather than the brokerId




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org