You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/11/12 13:38:00 UTC

[jira] [Commented] (AIRFLOW-5893) Refactor CLI tests

    [ https://issues.apache.org/jira/browse/AIRFLOW-5893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972405#comment-16972405 ] 

ASF subversion and git services commented on AIRFLOW-5893:
----------------------------------------------------------

Commit d59b731657c9fcde781aa89a59733c1d66318c8e in airflow's branch refs/heads/master from Kamil Breguła
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=d59b731 ]

[AIRFLOW-5894][part of AIRFLOW-5893] Group tests for the Dags command (#6543)

* [AIRFLOW-5894] Group tests for the Dags command

> Refactor CLI tests
> ------------------
>
>                 Key: AIRFLOW-5893
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5893
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: 1.10.6
>            Reporter: Kamil Bregula
>            Priority: Major
>
> Hello
> Currently, CLI tests are not ordered, which makes it difficult to find the correct test, and also makes it difficult to introduce further improvements.
> Currently CLI tests are in the following classes:
>  * tests.cli.test_cli.TestCLI
>  * tests.core.TestCli
> I would like to take action to group the tests according to the base command, which creates the following classes:
>  * tests.cli.test_cli.TestConnections
>  * tests.cli.test_cli.TestDags
>  * tests.cli.test_cli.TestDb
>  * tests.cli.test_cli.TestFlower
>  * tests.cli.test_cli.TestKerberos
>  * tests.cli.test_cli.TestPools
>  * tests.cli.test_cli.TestRoles
>  * tests.cli.test_cli.TestRotateFernetKey
>  * tests.cli.test_cli.TestScheduler
>  * tests.cli.test_cli.TestServeLogs
>  * tests.cli.test_cli.TestSyncPerm
>  * tests.cli.test_cli.TestTasks
>  * tests.cli.test_cli.TestUsers
>  * tests.cli.test_cli.TestVariables
>  * tests.cli.test_cli.TestVersion
>  * tests.cli.test_cli.TestWebserver
>  * tests.cli.test_cli.TestWorker
> The change will make it easier to make subsequent changes for this component: In particular, split the component cli.py file into separate modules, and then introduce lazy module loading. Currently, all modules are loaded with all dependencies every time. This process is time consuming.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)