You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/27 19:54:36 UTC
[GitHub] [iceberg] wypoon opened a new pull request, #4885: Docs: Fix a typo. Add using for writeTo when creating a table.
wypoon opened a new pull request, #4885:
URL: https://github.com/apache/iceberg/pull/4885
Fix two issues in Spark documentation.
1. Typo in Spark DDL doc.
2. Examples for creating/replacing a table using `writeTo` need `using("iceberg")`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4885: Docs: Fix a typo. Add using for writeTo when creating a table.
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4885:
URL: https://github.com/apache/iceberg/pull/4885#issuecomment-1140536066
Looks great. Thanks for updating this, @wypoon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4885: Docs: Fix a typo. Add using for writeTo when creating a table.
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4885:
URL: https://github.com/apache/iceberg/pull/4885#discussion_r884331909
##########
docs/spark/spark-writes.md:
##########
@@ -287,13 +287,14 @@ To run a CTAS or RTAS, use `create`, `replace`, or `createOrReplace` operations:
```scala
val data: DataFrame = ...
-data.writeTo("prod.db.table").create()
+data.writeTo("prod.db.table").using("iceberg").create()
Review Comment:
For the `SparkSessionCatalog`, you do need this. It might be better just to recommend it here, although it isn't needed unless we are trying to determine whether to pass the create through to the underlying catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on a diff in pull request #4885: Docs: Fix a typo. Add using for writeTo when creating a table.
Posted by GitBox <gi...@apache.org>.
wypoon commented on code in PR #4885:
URL: https://github.com/apache/iceberg/pull/4885#discussion_r884332192
##########
docs/spark/spark-writes.md:
##########
@@ -287,13 +287,14 @@ To run a CTAS or RTAS, use `create`, `replace`, or `createOrReplace` operations:
```scala
val data: DataFrame = ...
-data.writeTo("prod.db.table").create()
+data.writeTo("prod.db.table").using("iceberg").create()
Review Comment:
I reverted the change and added a clarification for when you use `SparkSessionCatalog`. Please let me know if you think it is better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4885: Docs: Fix a typo. Add using for writeTo when creating a table.
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4885:
URL: https://github.com/apache/iceberg/pull/4885#discussion_r884322890
##########
docs/spark/spark-writes.md:
##########
@@ -287,13 +287,14 @@ To run a CTAS or RTAS, use `create`, `replace`, or `createOrReplace` operations:
```scala
val data: DataFrame = ...
-data.writeTo("prod.db.table").create()
+data.writeTo("prod.db.table").using("iceberg").create()
Review Comment:
This depends on the catalog. If you're using an Iceberg catalog, it shouldn't be necessary to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on a diff in pull request #4885: Docs: Fix a typo. Add using for writeTo when creating a table.
Posted by GitBox <gi...@apache.org>.
wypoon commented on code in PR #4885:
URL: https://github.com/apache/iceberg/pull/4885#discussion_r884330822
##########
docs/spark/spark-writes.md:
##########
@@ -287,13 +287,14 @@ To run a CTAS or RTAS, use `create`, `replace`, or `createOrReplace` operations:
```scala
val data: DataFrame = ...
-data.writeTo("prod.db.table").create()
+data.writeTo("prod.db.table").using("iceberg").create()
Review Comment:
Thanks for pointing that out. I did not actually know that. I usually use the `SparkSessionCatalog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4885: Docs: Fix a typo. Add using for writeTo when creating a table.
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4885:
URL: https://github.com/apache/iceberg/pull/4885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org