You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/04 10:54:47 UTC
[GitHub] [arrow] kszucs opened a new pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
kszucs opened a new pull request #10865:
URL: https://github.com/apache/arrow/pull/10865
I'm not sure whether this is going to work on a amd64 linux host, but it actually runs on docker for mac.
@pitrou could you please try `ARCH=i386 archery docker run debian-cpp` locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-981732716
@github-actions crossbow submit test-debian-11-cpp-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#discussion_r758566511
##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -3451,7 +3451,7 @@ TEST_F(TestInt64QuantileKernel, Int64) {
#undef DOUBLE
#undef O
-#ifndef __MINGW32__
+#if ARROW_BITNESS != 32
Review comment:
Instead of skipping this on all 32-bit platforms, can you skip only on x86?
##########
File path: dev/tasks/tasks.yml
##########
@@ -984,14 +984,18 @@ tasks:
flags: -e ARROW_SKYHOOK=ON
image: ubuntu-cpp
-{% for debian_version in ["10", "11"] %}
- test-debian-{{ debian_version }}-cpp:
+{% for arch, flags in [("amd64", ""), ("i386", "-e ARROW_S3=OFF -e ARROW_GANDIVA=OFF")] %}
Review comment:
Nit, but for readability and maintainability I'd favour separate snippets for amd64 and i386.
##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -73,7 +73,9 @@ RUN apt-get update -y -q && \
COPY ci/scripts/install_minio.sh \
/arrow/ci/scripts/
-RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
+RUN if [ "${arch}" != "i386" ]; then \
+ /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local; \
Review comment:
Instead of putting the `if` here, put it in the download script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#discussion_r759185278
##########
File path: dev/tasks/tasks.yml
##########
@@ -984,14 +984,18 @@ tasks:
flags: -e ARROW_SKYHOOK=ON
image: ubuntu-cpp
-{% for debian_version in ["10", "11"] %}
- test-debian-{{ debian_version }}-cpp:
+{% for arch, flags in [("amd64", ""), ("i386", "-e ARROW_S3=OFF -e ARROW_GANDIVA=OFF")] %}
Review comment:
Sure, I can separate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-892562096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-892562096
https://issues.apache.org/jira/browse/ARROW-3699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-981768278
Revision: 60376139711e147d7aedde1550c93fe8df9872c1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1213](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1213)
|Task|Status|
|----|------|
|test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1213-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1213-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1213-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1213-github-test-debian-10-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-892586959
> ARCH=i386 archery docker run -e ARROW_GANDIVA=OFF -e ARROW_S3=OFF debian-cpp
There's a test failure, but apart from that it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984152455
Revision: 738828dd0aab133c9c4051e0a1bf4aa11e71413e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1233](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1233)
|Task|Status|
|----|------|
|test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1233-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1233-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1233-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1233-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1233-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1233-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1233-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1233-github-test-debian-11-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-981641445
Revision: 0e2dcd01dfedae60b2e2dc6df07d9839aef1454d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1211](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1211)
|Task|Status|
|----|------|
|test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1211-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1211-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1211-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1211-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1211-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1211-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1211-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1211-github-test-debian-11-cpp-i386)|
|test-debian-11-go-1.15|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-1211-azure-test-debian-11-go-1.15)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1211-azure-test-debian-11-go-1.15)|
|test-debian-11-python-3|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-1211-azure-test-debian-11-python-3)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1211-azure-test-debian-11-python-3)|
|test-debian-c-glib|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1211-github-test-debian-c-glib)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1211-github-test-debian-c-glib)|
|test-debian-ruby|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1211-github-test-debian-ruby)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1211-github-test-debian-ruby)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984606894
Benchmark runs are scheduled for baseline = be9a22b9b76d9cd83d85d52ffc2844056d90f367 and contender = 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4. 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7b2588371514cd48337e9fad012effd...60120d65550d471ca7263b32b7a87b2e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/05f2e9967f5b4f0d8a20247b2b3025f4...4d02f3c18ca449bb87f079cba89df904/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/455d50134ff2448eb67ac6363830e9d5...c3fffec0c04e455dbe7eb7455627fd31/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-892620064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-892620764
Revision: e8a466f7b338d811df321f524c2e54ff7cd1f692
Submitted crossbow builds: [ursacomputing/crossbow @ actions-712](https://github.com/ursacomputing/crossbow/branches/all?query=actions-712)
|Task|Status|
|----|------|
|test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-712-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-712-github-test-debian-10-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#discussion_r682509076
##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -73,7 +73,9 @@ RUN apt-get update -y -q && \
COPY ci/scripts/install_minio.sh \
/arrow/ci/scripts/
-RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
+RUN if [ "${arch}" != "i386" ]; then \
+ /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local; \
Review comment:
Can't find a binary for i386 here: https://dl.min.io/server/minio/release/
Possibly need to set `ARROW_S3=OFF` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-892586959
> ARCH=i386 archery docker run -e ARROW_GANDIVA=OFF -e ARROW_S3=OFF debian-cpp
There's a test failure, but apart from that it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-892620064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984606894
Benchmark runs are scheduled for baseline = be9a22b9b76d9cd83d85d52ffc2844056d90f367 and contender = 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4. 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7b2588371514cd48337e9fad012effd...60120d65550d471ca7263b32b7a87b2e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/05f2e9967f5b4f0d8a20247b2b3025f4...4d02f3c18ca449bb87f079cba89df904/)
[Finished :arrow_down:0.44% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/455d50134ff2448eb67ac6363830e9d5...c3fffec0c04e455dbe7eb7455627fd31/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#discussion_r712171010
##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -73,7 +73,9 @@ RUN apt-get update -y -q && \
COPY ci/scripts/install_minio.sh \
/arrow/ci/scripts/
-RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
+RUN if [ "${arch}" != "i386" ]; then \
+ /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local; \
Review comment:
Probably because nobody cares :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-981640600
@github-actions crossbow submit test-debian-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984090826
Revision: 24583f04a900252c1e86b99864fab6ae9604f8af
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1230](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1230)
|Task|Status|
|----|------|
|test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1230-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1230-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1230-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1230-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1230-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1230-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1230-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1230-github-test-debian-11-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984097328
Revision: 753e38aae4eddf3083fa52c9dd8d6517a0e00d4f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1231](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1231)
|Task|Status|
|----|------|
|test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1231-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1231-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1231-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1231-github-test-debian-10-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984096653
@github-actions crossbow submit test-debian-10-cpp-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984606894
Benchmark runs are scheduled for baseline = be9a22b9b76d9cd83d85d52ffc2844056d90f367 and contender = 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4. 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7b2588371514cd48337e9fad012effd...60120d65550d471ca7263b32b7a87b2e/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/05f2e9967f5b4f0d8a20247b2b3025f4...4d02f3c18ca449bb87f079cba89df904/)
[Finished :arrow_down:0.44% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/455d50134ff2448eb67ac6363830e9d5...c3fffec0c04e455dbe7eb7455627fd31/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-922917618
Revision: 08c7b63abbc54ed0743dd07b68a545cf0e27c5ac
Submitted crossbow builds: [ursacomputing/crossbow @ actions-847](https://github.com/ursacomputing/crossbow/branches/all?query=actions-847)
|Task|Status|
|----|------|
|test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-847-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-847-github-test-debian-10-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-893777793
I don't think that we need more i386 builds.
We can detect general i386 related build/test failures by the added Debian task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984606894
Benchmark runs are scheduled for baseline = be9a22b9b76d9cd83d85d52ffc2844056d90f367 and contender = 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4. 0da15b69ff31ffb05a4f0ffa7fbede30134b8cf4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7b2588371514cd48337e9fad012effd...60120d65550d471ca7263b32b7a87b2e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/05f2e9967f5b4f0d8a20247b2b3025f4...4d02f3c18ca449bb87f079cba89df904/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/455d50134ff2448eb67ac6363830e9d5...c3fffec0c04e455dbe7eb7455627fd31/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-981733973
Revision: 60376139711e147d7aedde1550c93fe8df9872c1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1212](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1212)
|Task|Status|
|----|------|
|test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1212-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1212-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1212-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1212-github-test-debian-11-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-893293993
There is a failing test case, but the overall build configuration works.
@kou shall we configure i386 builds for other distributions as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#discussion_r682509076
##########
File path: ci/docker/debian-10-cpp.dockerfile
##########
@@ -73,7 +73,9 @@ RUN apt-get update -y -q && \
COPY ci/scripts/install_minio.sh \
/arrow/ci/scripts/
-RUN /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local
+RUN if [ "${arch}" != "i386" ]; then \
+ /arrow/ci/scripts/install_minio.sh ${arch} linux latest /usr/local; \
Review comment:
Can't find a binary for i386 here: https://dl.min.io/server/minio/release/
Possibly need to set `ARROW_S3=OFF` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-922916752
@github-actions crossbow submit test-debian-10-cpp-i386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-981767077
@github-actions crossbow submit test-debian-10-cpp-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984090153
@github-actions crossbow submit test-debian-*-cpp-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10865:
URL: https://github.com/apache/arrow/pull/10865#issuecomment-984151846
@github-actions crossbow submit test-debian-*-cpp-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10865: ARROW-3699: [C++] Dockerfile for testing 32-bit C++ build
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10865:
URL: https://github.com/apache/arrow/pull/10865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org