You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/29 11:13:42 UTC
[GitHub] [arrow] rtpsw opened a new pull request, #14765: ARROW-18402: [C++] Expose `DeclarationInfo`
rtpsw opened a new pull request, #14765:
URL: https://github.com/apache/arrow/pull/14765
See https://issues.apache.org/jira/browse/ARROW-18402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on pull request #14765: ARROW-18402: [C++] Expose `DeclarationInfo`
Posted by GitBox <gi...@apache.org>.
rtpsw commented on PR #14765:
URL: https://github.com/apache/arrow/pull/14765#issuecomment-1330467064
cc @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14765: ARROW-18402: [C++] Expose `DeclarationInfo`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14765:
URL: https://github.com/apache/arrow/pull/14765#issuecomment-1340866789
Benchmark runs are scheduled for baseline = 9b0f3d71a99f0d14f6d8e51524dc5a74ca5cea8e and contender = ce738320c5ed727db64575c593796b9af4fdff49. ce738320c5ed727db64575c593796b9af4fdff49 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5d1914a0d5c24cd49f6340b22310665c...25f014551fed4eab8ee12ee8d7cd77fd/)
[Failed :arrow_down:0.03% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fcf2c64eddf148348d2a1003ccc238d6...54cfff6052644ed984157da62f3112b0/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5a328f351039401590ec949ba819b41b...d7a41ad6535442e092486e8c54c6a147/)
[Finished :arrow_down:0.52% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dd14a9ade303434bb9d6fc3777e46d48...6ac85eda581742e4ac496ed7fc3f8ac9/)
Buildkite builds:
[Finished] [`ce738320` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1982)
[Failed] [`ce738320` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2004)
[Finished] [`ce738320` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1974)
[Finished] [`ce738320` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1996)
[Finished] [`9b0f3d71` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1981)
[Finished] [`9b0f3d71` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2003)
[Finished] [`9b0f3d71` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1973)
[Finished] [`9b0f3d71` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1995)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14765: ARROW-18402: [C++] Expose `DeclarationInfo`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14765:
URL: https://github.com/apache/arrow/pull/14765#issuecomment-1330467167
https://issues.apache.org/jira/browse/ARROW-18402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #14765: ARROW-18402: [C++] Expose `DeclarationInfo`
Posted by GitBox <gi...@apache.org>.
westonpace merged PR #14765:
URL: https://github.com/apache/arrow/pull/14765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #14765: ARROW-18402: [C++] Expose `DeclarationInfo`
Posted by GitBox <gi...@apache.org>.
westonpace commented on code in PR #14765:
URL: https://github.com/apache/arrow/pull/14765#discussion_r1040609914
##########
cpp/src/arrow/engine/substrait/relation.h:
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "arrow/compute/exec/exec_plan.h"
Review Comment:
```suggestion
#include <memory>
#include "arrow/compute/exec/exec_plan.h"
```
Minor IWYU nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org