[GitHub] [druid] suneet-s commented on a change in pull request #10996: CompactionTask throws exception on conflicting segmentGranularity

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #10996:
URL: https://github.com/apache/druid/pull/10996#discussion_r594798377



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java
##########
@@ -207,6 +208,16 @@ public CompactionTask(
     this.dimensionsSpec = dimensionsSpec == null ? dimensions : dimensionsSpec;
     this.metricsSpec = metricsSpec;
     this.segmentGranularity = segmentGranularity;
+    if (granularitySpec != null
+        && segmentGranularity != null
+        && !segmentGranularity.equals(granularitySpec.getSegmentGranularity())) {

Review comment:
       I couldn't decide what it means to have a `granularitySpec.getSegmentGranularity()` be null and segmentGranularity be non null, so I figured it would be good to flag that as a conflict as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org