You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/09 09:28:13 UTC
[GitHub] [tvm] jacquesguan opened a new pull request, #13587: [Frontend] [ONNX] Support sequence_lens of GRU.
jacquesguan opened a new pull request, #13587:
URL: https://github.com/apache/tvm/pull/13587
Support convert sequence_lens input of GRU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU.
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13587:
URL: https://github.com/apache/tvm/pull/13587#issuecomment-1344064832
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @KJlaccHoeUM9l, @ehsanmok <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vvchernov commented on a diff in pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU
Posted by GitBox <gi...@apache.org>.
vvchernov commented on code in PR #13587:
URL: https://github.com/apache/tvm/pull/13587#discussion_r1046836569
##########
python/tvm/relay/frontend/common.py:
##########
@@ -737,6 +737,7 @@ def gru_cell(
n_act=_op.tanh,
backwards=False,
linear_before_reset=True,
Review Comment:
Please add description of arguments `linear_before_reset` and `sequence_lens`
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -4211,6 +4218,22 @@ def verify_rnn_helper(target, dev, rnn_type):
# dev=dev,
# )
+ # Testing with initial state
+ if rnn_type == "GRU":
+ verify_rnn(
+ seq_length=2,
Review Comment:
Please increase seq_length (to 4-5 or more) and batch_size (to 4-8) for correct test of sequence with different lengths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13587:
URL: https://github.com/apache/tvm/pull/13587#issuecomment-1347594470
cc @vvchernov @AndrewZhaoLuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jacquesguan commented on a diff in pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU
Posted by GitBox <gi...@apache.org>.
jacquesguan commented on code in PR #13587:
URL: https://github.com/apache/tvm/pull/13587#discussion_r1048177604
##########
python/tvm/relay/frontend/common.py:
##########
@@ -737,6 +737,7 @@ def gru_cell(
n_act=_op.tanh,
backwards=False,
linear_before_reset=True,
Review Comment:
Done.
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -4211,6 +4218,22 @@ def verify_rnn_helper(target, dev, rnn_type):
# dev=dev,
# )
+ # Testing with initial state
+ if rnn_type == "GRU":
+ verify_rnn(
+ seq_length=2,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU
Posted by GitBox <gi...@apache.org>.
masahi merged PR #13587:
URL: https://github.com/apache/tvm/pull/13587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jacquesguan commented on pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU.
Posted by GitBox <gi...@apache.org>.
jacquesguan commented on PR #13587:
URL: https://github.com/apache/tvm/pull/13587#issuecomment-1344068388
Could you please review this PR @masahi? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #13587:
URL: https://github.com/apache/tvm/pull/13587#issuecomment-1347321118
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org