[jira] [Commented] (HAWQ-1717) Incorrect seeding for random function

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAWQ-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838215#comment-16838215 ] 

ASF GitHub Bot commented on HAWQ-1717:
--------------------------------------

huor commented on pull request #1447: HAWQ-1717. Fix incorrect seeding for random function
URL: https://github.com/apache/hawq/pull/1447
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Incorrect seeding for random function
> -------------------------------------
>
>                 Key: HAWQ-1717
>                 URL: https://issues.apache.org/jira/browse/HAWQ-1717
>             Project: Apache HAWQ
>          Issue Type: Bug
>          Components: Core
>            Reporter: Ruilong Huo
>            Assignee: Ruilong Huo
>            Priority: Major
>
> {code:c}
> $ cat src/port/rand.c
> /*
>  * $PostgreSQL: pgsql/src/port/rand.c,v 1.6 2009/06/11 14:49:15 momjian Exp $
>  *
>  *-------------------------------------------------------------------------
>  *
>  * rand.c
>  *	  Missing rand implementations for Win32
>  *
>  *-------------------------------------------------------------------------
>  */
> ...
> void
> srand48(long seed)
> {
> 	_rand48_seed[0] = RAND48_SEED_0;
> 	_rand48_seed[1] = (unsigned short) seed;
> 	_rand48_seed[2] = (unsigned short) (seed > 16);
> 	_rand48_mult[0] = RAND48_MULT_0;
> 	_rand48_mult[1] = RAND48_MULT_1;
> 	_rand48_mult[2] = RAND48_MULT_2;
> 	_rand48_add = RAND48_ADD;
> }
> ```
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)