You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/07/05 21:26:36 UTC
[GitHub] nifi pull request #604: [NIFI-2038] Make component buttons larger and add gr...
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/604
[NIFI-2038] Make component buttons larger and add grip across bottom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi devBranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #604
----
commit 2138e5a77996684e282c166e6987d26df340dfe7
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-07-05T21:25:46Z
[NIFI-2038] Make component buttons larger and add grip across bottom
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIF...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/604#discussion_r69896628
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/header.css ---
@@ -34,12 +34,13 @@ md-toolbar.md-small .md-toolbar-tools {
}
#header .icon {
- font-size:30px;
+ font-size:32px;
color: #004849;
+ padding-left:6px
--- End diff --
@scottyaslan looks like the 6px padding-left was not enough to center the icons within each button. I must have misjudged it originally. Changing it to 12px works for me now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/604
\u200b**NIFI-2031** looks good
For **NIFI-2036,** NiFi logo seems to sit a little low after the other toolbar changes. Please *change* `margin:0 20px 0 15px;` *to* `margin:0 20px 3px 15px;`
\u200bFor **NIFI-2037** `#header .icon` and `#header .fa` should be `font-size:32px`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/604
Everything is looking good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIF...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/604#discussion_r69900469
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-toolbox-controller.js ---
@@ -94,12 +94,21 @@ nf.ng.Canvas.ToolboxCtrl = function (processorComponent,
* NOTE: The `component` must implement a dropHandler.
*/
draggableComponentConfig: function(component) {
+
+ //add hover effect
+ component.getElement().hover(function () {
+ component.getElement().removeClass(component.icon).addClass(component.hoverIcon);
+ }, function () {
+ component.getElement().removeClass(component.hoverIcon).addClass(component.icon);
+ })
+
return {
zIndex: 1011,
revert: true,
revertDuration: 0,
cancel: false,
containment: 'body',
+ cursor: 'grabbing',
--- End diff --
I can try this...but I don't think jQuery UI will like that....it is not like CSS in this case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/604
Looks good @scottyaslan! This has been merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIF...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/604#discussion_r69898927
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-toolbox-controller.js ---
@@ -94,12 +94,21 @@ nf.ng.Canvas.ToolboxCtrl = function (processorComponent,
* NOTE: The `component` must implement a dropHandler.
*/
draggableComponentConfig: function(component) {
+
+ //add hover effect
+ component.getElement().hover(function () {
+ component.getElement().removeClass(component.icon).addClass(component.hoverIcon);
+ }, function () {
+ component.getElement().removeClass(component.hoverIcon).addClass(component.icon);
+ })
+
return {
zIndex: 1011,
revert: true,
revertDuration: 0,
cancel: false,
containment: 'body',
+ cursor: 'grabbing',
--- End diff --
@scottyaslan I think we can add `cursor: '-moz-grabbing'` and `cursor: '-webkit-grabbing'` vendor prefixes here to get the cursor to show on non-supported browsers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/604
@moranr I have addressed all comments and updated the PR.
@mcgilman ready for review please sir
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIF...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/604
For **NIFI-2038**
* For #header .component-button, height and width properties are declared twice at 40px and 56px. Should only be 56px
* Icons (#header .icon and #header .fa) should be 32px (\u200b\u200bNIFI-2037)
* Looks like #header .icon \u200bwill need padding-left:6px added to center them within the button\u200bs (once size is updated to 32px)\u200b
* The version of each icon with a plus should display on hover. Currently it only shows once you start dragging
* When button is click and while dragging, set cursor to cursor:grabbing
See mockup as example (nifi-drag-drop-component.png)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/604
**NIFI-2144** looks good \u2013 seeing the correct icons in place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---