You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "John Sisson (JIRA)" <de...@geronimo.apache.org> on 2006/04/11 02:42:00 UTC
[jira] Created: (GERONIMO-1824) geronimo-config-1.0.xsd incorrectly
documents that classes can be comma-separated inside a a filter element
geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a a filter element
-----------------------------------------------------------------------------------------------------------
Key: GERONIMO-1824
URL: http://issues.apache.org/jira/browse/GERONIMO-1824
Project: Geronimo
Type: Bug
Security: public (Regular issues)
Components: deployment, kernel
Versions: 1.0
Reporter: John Sisson
Priority: Minor
Fix For: 1.1
The current implementation of MultiparentClassloader does not parse comma-separated values. Therefore if you specify a filter such as:
<hidden-classes>
<filter>com.acme.producta,com.acme.productb</filter>
</hidden-classes>
Then when loading the class "com.acme.productb" it will not match the hidden-classes filter as the MultiParentClassloader logic just does a simple name.startsWith(hiddenClasses[i]) test, where hiddenClasses[0] will be "com.acme.producta,com.acme.productb".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Created: (GERONIMO-1824) geronimo-config-1.0.xsd incorrectly
documents that classes can be comma-separated inside a a filter element
Posted by John Sisson <jr...@gmail.com>.
Should we just update the documentation in the schema to reflect the
code? Should we be avoiding having XML elements that require further
parsing (e.g. for comma-separated values) so that other tools can
process the XML easily?
John
John Sisson (JIRA) wrote:
> geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a a filter element
> -----------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-1824
> URL: http://issues.apache.org/jira/browse/GERONIMO-1824
> Project: Geronimo
> Type: Bug
> Security: public (Regular issues)
> Components: deployment, kernel
> Versions: 1.0
> Reporter: John Sisson
> Priority: Minor
> Fix For: 1.1
>
>
> The current implementation of MultiparentClassloader does not parse comma-separated values. Therefore if you specify a filter such as:
>
> <hidden-classes>
> <filter>com.acme.producta,com.acme.productb</filter>
> </hidden-classes>
>
> Then when loading the class "com.acme.productb" it will not match the hidden-classes filter as the MultiParentClassloader logic just does a simple name.startsWith(hiddenClasses[i]) test, where hiddenClasses[0] will be "com.acme.producta,com.acme.productb".
>
>
>
[jira] Updated: (GERONIMO-1824) geronimo-config-1.0.xsd incorrectly
documents that classes can be comma-separated inside a filter element
Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1824?page=all ]
John Sisson updated GERONIMO-1824:
----------------------------------
Summary: geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a filter element (was: geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a a filter element)
> geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a filter element
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-1824
> URL: http://issues.apache.org/jira/browse/GERONIMO-1824
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment, kernel
> Versions: 1.0
> Reporter: John Sisson
> Priority: Minor
> Fix For: 1.1
>
> The current implementation of MultiparentClassloader does not parse comma-separated values. Therefore if you specify a filter such as:
> <hidden-classes>
> <filter>com.acme.producta,com.acme.productb</filter>
> </hidden-classes>
> Then when loading the class "com.acme.productb" it will not match the hidden-classes filter as the MultiParentClassloader logic just does a simple name.startsWith(hiddenClasses[i]) test, where hiddenClasses[0] will be "com.acme.producta,com.acme.productb".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1824) geronimo-config-1.0.xsd
incorrectly documents that classes can be comma-separated inside a filter
element
Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1824?page=all ]
John Sisson reassigned GERONIMO-1824:
-------------------------------------
Assign To: John Sisson
> geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a filter element
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-1824
> URL: http://issues.apache.org/jira/browse/GERONIMO-1824
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment, kernel
> Versions: 1.0
> Reporter: John Sisson
> Assignee: John Sisson
> Priority: Minor
> Fix For: 1.1
>
> The current implementation of MultiparentClassloader does not parse comma-separated values. Therefore if you specify a filter such as:
> <hidden-classes>
> <filter>com.acme.producta,com.acme.productb</filter>
> </hidden-classes>
> Then when loading the class "com.acme.productb" it will not match the hidden-classes filter as the MultiParentClassloader logic just does a simple name.startsWith(hiddenClasses[i]) test, where hiddenClasses[0] will be "com.acme.producta,com.acme.productb".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1824) geronimo-config-1.0.xsd
incorrectly documents that classes can be comma-separated inside a filter
element
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1824?page=comments#action_12374258 ]
David Jencks commented on GERONIMO-1824:
----------------------------------------
I think we should not allow comma-separated filters, but require
<hidden-classes>
<filter>com.acme.producta</filter>
<filter>com.acme.productb</filter>
</hidden-classes>
> geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a filter element
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-1824
> URL: http://issues.apache.org/jira/browse/GERONIMO-1824
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment, kernel
> Versions: 1.0
> Reporter: John Sisson
> Assignee: John Sisson
> Priority: Minor
> Fix For: 1.1
>
> The current implementation of MultiparentClassloader does not parse comma-separated values. Therefore if you specify a filter such as:
> <hidden-classes>
> <filter>com.acme.producta,com.acme.productb</filter>
> </hidden-classes>
> Then when loading the class "com.acme.productb" it will not match the hidden-classes filter as the MultiParentClassloader logic just does a simple name.startsWith(hiddenClasses[i]) test, where hiddenClasses[0] will be "com.acme.producta,com.acme.productb".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1824) geronimo-config-1.0.xsd
incorrectly documents that classes can be comma-separated inside a filter
element
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1824?page=comments#action_12374262 ]
Jeff Genender commented on GERONIMO-1824:
-----------------------------------------
I completely agree with David Jencks. We should have multiple filter lines instead of comma delimited.
> geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a filter element
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-1824
> URL: http://issues.apache.org/jira/browse/GERONIMO-1824
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment, kernel
> Versions: 1.0
> Reporter: John Sisson
> Assignee: John Sisson
> Priority: Minor
> Fix For: 1.1
>
> The current implementation of MultiparentClassloader does not parse comma-separated values. Therefore if you specify a filter such as:
> <hidden-classes>
> <filter>com.acme.producta,com.acme.productb</filter>
> </hidden-classes>
> Then when loading the class "com.acme.productb" it will not match the hidden-classes filter as the MultiParentClassloader logic just does a simple name.startsWith(hiddenClasses[i]) test, where hiddenClasses[0] will be "com.acme.producta,com.acme.productb".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-1824) geronimo-config-1.0.xsd incorrectly
documents that classes can be comma-separated inside a filter element
Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1824?page=all ]
John Sisson closed GERONIMO-1824:
---------------------------------
Resolution: Fixed
Documentation in schema updated.
> geronimo-config-1.0.xsd incorrectly documents that classes can be comma-separated inside a filter element
> ---------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-1824
> URL: http://issues.apache.org/jira/browse/GERONIMO-1824
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: deployment, kernel
> Versions: 1.0
> Reporter: John Sisson
> Assignee: John Sisson
> Priority: Minor
> Fix For: 1.1
>
> The current implementation of MultiparentClassloader does not parse comma-separated values. Therefore if you specify a filter such as:
> <hidden-classes>
> <filter>com.acme.producta,com.acme.productb</filter>
> </hidden-classes>
> Then when loading the class "com.acme.productb" it will not match the hidden-classes filter as the MultiParentClassloader logic just does a simple name.startsWith(hiddenClasses[i]) test, where hiddenClasses[0] will be "com.acme.producta,com.acme.productb".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira