You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2011/09/01 16:12:09 UTC

[jira] [Commented] (HADOOP-7598) smart-apply-patch.sh does not handle patching from a sub directory correctly.

    [ https://issues.apache.org/jira/browse/HADOOP-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095305#comment-13095305 ] 

Robert Joseph Evans commented on HADOOP-7598:
---------------------------------------------

@Luke

Thanks for taking the time to look at the patch and show that it was wrong.  I took the time this morning and dug into it.  It turns out that the combination of commands used to get the base directories also prepends a "\n" to the output.  So all of the regular expressions that were checking for specific directories were failing because of the leading blank line.  I am not sure if this is due to differences between the system that smart-apply-patch.sh was developed on originally or what, but when I added in a command to strip out all of the blank lines from the output then everything worked correctly.

> smart-apply-patch.sh does not handle patching from a sub directory correctly.
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-7598
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7598
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7598-v1.patch, HADOOP-7598-v2.patch
>
>
> smart-apply-patch.sh does not apply valid patches from trunk, or from git like it was designed to do in some situations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira