You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2015/04/01 19:18:45 UTC

svn commit: r1670737 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java

Author: tilman
Date: Wed Apr  1 17:18:45 2015
New Revision: 1670737

URL: http://svn.apache.org/r1670737
Log:
PDFBOX-2576: remove public modifier of method of non public class; remove dead code (COSObjectable cannot be instanceof list); remove dead code line

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java?rev=1670737&r1=1670736&r2=1670737&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java Wed Apr  1 17:18:45 2015
@@ -46,7 +46,7 @@ class PDFCloneUtility
      * Creates a new instance for the given target document.
      * @param dest the destination PDF document that will receive the clones
      */
-    public PDFCloneUtility(PDDocument dest)
+    PDFCloneUtility(PDDocument dest)
     {
         this.destination = dest;
     }
@@ -184,16 +184,6 @@ class PDFCloneUtility
               return;
               //we are done, it has already been converted. // ### Is that correct for cloneMerge???
           }
-          else if( base instanceof List )
-          {
-              COSArray array = new COSArray();
-              List<?> list = (List<?>) base;
-              for (Object obj : list)
-              {
-                  array.add(cloneForNewDocument(obj));
-              }
-              ((List<COSArray>) target).add(array);
-          }
           else if( base instanceof COSObjectable && !(base instanceof COSBase) )
           {
               cloneMerge(base.getCOSObject(), target.getCOSObject());
@@ -233,7 +223,6 @@ class PDFCloneUtility
                           cloneForNewDocument(entry.getValue()));
               }
               retval = stream.getStream();
-              target = retval;
           }
           else if( base instanceof COSDictionary )
           {