You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/09 12:43:54 UTC
[GitHub] [doris] starocean999 opened a new pull request, #13227: [fix](join) should call getOutputTblRefIds to get child's tuple info
starocean999 opened a new pull request, #13227:
URL: https://github.com/apache/doris/pull/13227
# Proposed changes
Issue Number: close #xxx
## Problem summary
in hash join node, should call getOutputTblRefIds to get child's tuple info, this function works for both inlineViewRef and baseTblRef
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #13227: [fix](join) should call getOutputTblRefIds to get child's tuple info
Posted by GitBox <gi...@apache.org>.
luozenglin commented on PR #13227:
URL: https://github.com/apache/doris/pull/13227#issuecomment-1272724225
Does this pr solve the problem that #12261 wants to fix？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #13227: [fix](join) should call getOutputTblRefIds to get child's tuple info
Posted by GitBox <gi...@apache.org>.
starocean999 commented on PR #13227:
URL: https://github.com/apache/doris/pull/13227#issuecomment-1272969041
> Does this pr solve the problem that #12261 wants to fix？
yes, originally, the old pr just want to make the computeOutputTuple and computeIntermediateTuple both call getOutputTupleIds to keep consistent, but it's wrong. The two function should call diffrent method to get child's tuple info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13227: [fix](join) should call getOutputTblRefIds to get child's tuple info
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13227:
URL: https://github.com/apache/doris/pull/13227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org