You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/06/10 23:40:44 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #4505: optimizer ssl hint for cpp

merlimat commented on a change in pull request #4505: optimizer ssl hint for cpp
URL: https://github.com/apache/pulsar/pull/4505#discussion_r292231132
 
 

 ##########
 File path: pulsar-client-cpp/lib/ClientConnection.cc
 ##########
 @@ -119,6 +119,9 @@ static Result getResult(ServerError serverError) {
 }
 
 static bool file_exists(const std::string& path) {
+    if(path.empty()){
 
 Review comment:
   ```suggestion
       if (path.empty()){
   ```
   
   The format checker is failing on the missing space.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services