[GitHub] [doris] Gabriel39 commented on a diff in pull request #11277: [feature-wip] (datetimev2) support window funnel and modify valid dat…

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #11277:
URL: https://github.com/apache/doris/pull/11277#discussion_r931743971


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -1388,6 +1388,19 @@ private void initAggregateBuiltins() {
                 "",
                 "",
                 true, false, true, true));
+        addBuiltin(AggregateFunction.createBuiltin(FunctionSet.WINDOW_FUNNEL,

Review Comment:
   `window_funnel` will be searched in `IS_NONSTRICT_SUPERTYPE_OF` mode so DATEV2 could be cast to DATETIMEV2 implicitly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org