You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/04 05:14:59 UTC
[jira] [Commented] (NIFI-2948) AWS DynamoDB Processors Do Not
Update Credentials
[ https://issues.apache.org/jira/browse/NIFI-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635279#comment-15635279 ]
ASF GitHub Bot commented on NIFI-2948:
--------------------------------------
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/1182
NIFI-2948 Fix DynamoDB Cached Credentials
This is a minimal change to clear the cached DynamoDB Document Client containing credentials when the processor is stopped.
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-2948-dynamodb-creds-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1182
----
commit 619249cf5fd632537e17851177e56ac6989b9707
Author: James Wing <jv...@gmail.com>
Date: 2016-11-04T03:24:19Z
NIFI-2948 Fix DynamoDB Cached Credentials
----
> AWS DynamoDB Processors Do Not Update Credentials
> -------------------------------------------------
>
> Key: NIFI-2948
> URL: https://issues.apache.org/jira/browse/NIFI-2948
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0, 0.7.0
> Reporter: James Wing
> Priority: Minor
>
> Following a report to the dev email list, there appears to be a bug in the AWS DynamoDB processors where the AWS credentials are cached by the processor once started, and not updated even if the processor is stopped, reconfigured, and started.
> The problem appears to be [AbstractDynamoDBProcessor::getDynamoDB|https://github.com/apache/nifi/blob/rel/nifi-1.0.0/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/AbstractDynamoDBProcessor.java#L218], which assigns the dynamo client object to a class variable only once.
> *Repro Steps*
> # Add GetDynamoDB processor
> # Configure GetDynamoDB required properties but *not* any credential fields
> # Start the processor
> # Run a flowfile through - it should fail with "MissingAuthenticationTokenException" error
> # Stop the GetDynamoDB processor
> # Configure valid AWS credentials
> # Start the processor
> # Run a flowfile through - it should fail again with "MissingAuthenticationTokenException" still using the old credentials
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)