You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2015/11/23 15:20:48 UTC
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1393
[FLINK-3046] Integrate the Either Java type with the TypeExtractor
This PR implements FLINK-3046. All necessary methods of the TypeExtractor (`getForObject`, `createTypeInfo`, `getForClass` and `validdateInput`) have been updated for Either.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-3046
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1393
----
commit 2143ba2a4344deaac77c57d1abae351fd32920f0
Author: twalthr <tw...@apache.org>
Date: 2015-11-23T14:08:47Z
[FLINK-3046] Integrate the Either Java type with the TypeExtractor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159893451
Thanks for testing my PR. Sorry for the bug. I forgot to test the most obvious case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159871753
it gives the error : Usage of class Either as a type is not allowed. Use a concrete subclass instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159869432
Maybe I am not aware of the limitations but things like this dont seem to work:
TypeExtractor.getForObject(Either.<String, Long> left(""));
source.map(new MapFunction<Long, Either<Long, String>>() {
@Override
public Either<Long, String> map(Long value) throws Exception {
return null;
}
});
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159065510
This seems to work only on Java 8, it fails on all Java 7 builds on Travis...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159261689
Builds now ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159916143
Seems to work now :) :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159871232
The second variant should work (in the MapFunction signature) - if not, that is a bug.
The first variant cannot work because the type for "right" is nowhere in a non-erased form.
As a replacement for TypeExtractor.getForObject() I suggested that: https://issues.apache.org/jira/browse/FLINK-2788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-159983550
Will merge this tomorrow if no objections are raised.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3046] Integrate the Either Java type wi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1393#issuecomment-160109895
Looks good, has tests, Travis passes
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---