You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "bkietz (via GitHub)" <gi...@apache.org> on 2023/06/16 14:10:02 UTC
[GitHub] [arrow] bkietz opened a new issue, #36124: [C++] Export compile commands database by default
bkietz opened a new issue, #36124:
URL: https://github.com/apache/arrow/issues/36124
### Describe the enhancement requested
`CMakePresets.json` does not export compile commands by default. The relevant option is `"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",` and produces a file `compile_commands.json` which is used by clang tooling. The file is not huge; about 1MB. IMHO it'd be worthwhile to enable this by default so that developers always have access to it without needing to regenerate their cmake build dir; language servers and other tooling can be silently disabled without the compile commands database. See also [discussion here](https://github.com/apache/arrow/pull/36018#discussion_r1224861844)
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on issue #36124: [C++] Export compile commands database by default
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #36124:
URL: https://github.com/apache/arrow/issues/36124#issuecomment-1688616047
This sounds reasonable, do you want to do it @bkietz ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #36124: [C++] Export compile commands database by default
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #36124: [C++] Export compile commands database by default
URL: https://github.com/apache/arrow/issues/36124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on issue #36124: [C++] Export compile commands database by default
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #36124:
URL: https://github.com/apache/arrow/issues/36124#issuecomment-1594828609
I'm gonna +1 this issue as when I was setting up my tooling it took a bit of research before I found the `CMAKE_EXPORT_COMPILE_COMMANDS` option and it would have been much easier if it just exported the compile commands by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on issue #36124: [C++] Export compile commands database by default
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on issue #36124:
URL: https://github.com/apache/arrow/issues/36124#issuecomment-1594934762
+1, whenever I set up a new dev environment I'll need to google this variable because it's hard to remember the name verbatim. Would be nice to have it in the preset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on issue #36124: [C++] Export compile commands database by default
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #36124:
URL: https://github.com/apache/arrow/issues/36124#issuecomment-1594754990
CMake also reads this from an environment variable (in 3.17+), so developers can just individually set that in their shell configuration and get it for all CMake projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org