[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #12048: [Feature-12040][api][ui] Add authorization management of read and write permissions for project and resource center

[GitBox <gi...@apache.org>]

Amy0104 commented on code in PR #12048:
URL: https://github.com/apache/dolphinscheduler/pull/12048#discussion_r1000319737


##########
dolphinscheduler-ui/src/service/modules/projects/index.ts:
##########
@@ -26,6 +26,14 @@ export function queryProjectListPaging(params: ListReq): any {
   })
 }
 
+export function queryProjectWithAuthorizedLevelListPaging(params: any): any {

Review Comment:
   It's better to define the type for the params.



##########
dolphinscheduler-ui/src/views/security/user-manage/components/authorize-modal.tsx:
##########
@@ -43,14 +50,14 @@ const props = {
     default: 'auth_project'
   }
 }
-
+let projectIds: string

Review Comment:
   why define the projectIds here not inside the setup?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org