You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by bryanhiggins <gi...@git.apache.org> on 2014/05/13 20:33:36 UTC
[GitHub] cordova-plugin-contacts pull request: CB-6682 Move WP8 proxy to co...
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/30
CB-6682 Move WP8 proxy to correct platform element
@purplecabbage can you review this please?
This was being loaded by BB10 causing many contacts tests to fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry-webworks/cordova-plugin-contacts wp8fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit 60c0982225bd3e6861a2e3d2d70de7b9a0b90b75
Author: Bryan Higgins <bh...@blackberry.com>
Date: 2014-05-13T18:30:03Z
CB-6682 Move WP8 proxy to correct platform element
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: CB-6682 Move WP8 proxy to co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: CB-6682 Move WP8 proxy to co...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/30#issuecomment-42998251
It's still f'd, I'll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: CB-6682 Move WP8 proxy to co...
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/30#issuecomment-42999768
thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: CB-6682 Move WP8 proxy to co...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/30#issuecomment-42999990
anytime!
@purplecabbage
risingj.com
On Tue, May 13, 2014 at 12:19 PM, Bryan Higgins <no...@github.com>wrote:
> thanks
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/cordova-plugin-contacts/pull/30#issuecomment-42999768>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---