You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Bertil Chapuis (JIRA)" <ji...@apache.org> on 2011/02/11 07:56:59 UTC

[jira] Created: (DROIDS-116) replacing common logging by slf4j-api

replacing common logging by slf4j-api
-------------------------------------

                 Key: DROIDS-116
                 URL: https://issues.apache.org/jira/browse/DROIDS-116
             Project: Droids
          Issue Type: Bug
          Components: core
         Environment: It make more sense to have a dependency to slf4j since people who use droids may want to choose their logger.
            Reporter: Bertil Chapuis




-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertil Chapuis updated DROIDS-116:
----------------------------------

    Attachment: droids-116-v1.diff

Sets Slf4j as the default logger.
Erases the Loggable class.

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>         Attachments: droids-116-v1.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Florent ANDRE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993518#comment-12993518 ] 

Florent ANDRE commented on DROIDS-116:
--------------------------------------

may you already know it, but there is http://www.slf4j.org/migrator.html that can easiest the change.

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertil Chapuis updated DROIDS-116:
----------------------------------


I think it also may sense to remove the Loggable Helper class and to use the LoggerFactory in each class which requires a Logger.  

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (DROIDS-116) replacing common logging by slf4j-api

Posted by "Tobias Rübner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Rübner reopened DROIDS-116:
----------------------------------

      Assignee: Tobias Rübner

There are still some dependencies to commons-logging.
e.g. droids-core -> httpclient
                
> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>            Assignee: Tobias Rübner
>             Fix For: 0.0.1, 0.0.2
>
>         Attachments: droids-116-v1.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertil Chapuis updated DROIDS-116:
----------------------------------

    Fix Version/s: 0.0.2
       Issue Type: Improvement  (was: Bug)

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993503#comment-12993503 ] 

Ryan McKinley commented on DROIDS-116:
--------------------------------------

+1 

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertil Chapuis updated DROIDS-116:
----------------------------------

    Environment:     (was: It make more sense to have a dependency to slf4j since people who use droids may want to choose their logger.)

It make more sense to have use slf4j since people who use droids may want to choose their logger.

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (DROIDS-116) replacing common logging by slf4j-api

Posted by "Tobias Rübner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Rübner resolved DROIDS-116.
----------------------------------

    Resolution: Fixed

added excludes for commons-logging and added logging wrapper jcl-over-slf4j.

fixed with r1348877
                
> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>            Assignee: Tobias Rübner
>             Fix For: 0.0.1, 0.0.2
>
>         Attachments: droids-116-v1.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Closed: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertil Chapuis closed DROIDS-116.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.0.1

The patch has been updated and applied.

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.1, 0.0.2
>
>         Attachments: droids-116-v1.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993873#comment-12993873 ] 

Eugen Paraschiv commented on DROIDS-116:
----------------------------------------

+1

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (DROIDS-116) replacing common logging by slf4j-api

Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertil Chapuis updated DROIDS-116:
----------------------------------


Previously someone mentioned the fact that the Logger object should be static. Since Droids is a library I think it make sense to keep a Logger instance by Object while it's not really memory efficient. http://wiki.apache.org/jakarta-commons/Logging/StaticLog

> replacing common logging by slf4j-api
> -------------------------------------
>
>                 Key: DROIDS-116
>                 URL: https://issues.apache.org/jira/browse/DROIDS-116
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>             Fix For: 0.0.2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira