You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by la...@apache.org on 2022/06/20 18:50:17 UTC

[impala] 04/05: IMPALA-11366: Fix impala-shell build failure if the build date contains Non-ASCII characters

This is an automated email from the ASF dual-hosted git repository.

laszlog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 29e91220a2a1fcda0b35cddfa11492312b338743
Author: stiga-huang <hu...@gmail.com>
AuthorDate: Fri Jun 17 11:21:47 2022 +0800

    IMPALA-11366: Fix impala-shell build failure if the build date contains Non-ASCII characters
    
    The version string is generated in bin/save-version.sh where the
    BUILD_TIME is the result of `date` command. It could contain Non-ASCII
    characters depending on the locale. The date string is then used in
    generating impala_build_version.py. So we need to explicitly set the
    script's encoding to utf-8.
    
    Change-Id: I596121e08a52a4bc6d8668cf7e8b61b6c34eb4b9
    Reviewed-on: http://gerrit.cloudera.org:8080/18632
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Gergely Fürnstáhl <gf...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 shell/make_shell_tarball.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/shell/make_shell_tarball.sh b/shell/make_shell_tarball.sh
index 395a14382..502e8ab7c 100755
--- a/shell/make_shell_tarball.sh
+++ b/shell/make_shell_tarball.sh
@@ -73,6 +73,7 @@ mkdir -p ${TARBALL_ROOT}/ext-py
 
 rm -f ${THRIFT_GEN_PY_DIR}/impala_build_version.py
 cat > ${THRIFT_GEN_PY_DIR}/impala_build_version.py <<EOF
+# -*- coding: utf-8 -*-
 #
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file