[jira] [Reopened] (NIFI-6126) Change nf-canvas to respond to keyup events rather than keydown

["Robert Fellows (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NIFI-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Fellows reopened NIFI-6126:
----------------------------------

We can't depend on keyup events for our hotkeys. If we wait for keyup, the browser's own key listeners can act on the events first and change the event details that indicate the metaKey was active at the time of the event. That information gets removed. As a result, CMD-R, CMD-A and the like are not functional as they used to be when we attached to keydown.

So, the solution should be to once again attach to keydown but throttle the requests to canvas reload to only allow a request once every so many milliseconds to prevent potential overloading of the server with requests when holding down CTRL-R (or CMD-R). That was the real impetus for this case originally.

> Change nf-canvas to respond to keyup events rather than keydown
> ---------------------------------------------------------------
>
>                 Key: NIFI-6126
>                 URL: https://issues.apache.org/jira/browse/NIFI-6126
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>    Affects Versions: 1.9.0
>            Reporter: Robert Fellows
>            Assignee: Robert Fellows
>            Priority: Major
>             Fix For: 1.10.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> nf-canvas responds to keydown events currently. This allows for a scenario where the user can hold down CTRL + R and continuously refresh the canvas, sending many requests to the server and potentially cause a Denial of Service.
> It really should be listening for keyup instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)