You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/22 17:11:59 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
xinrong-databricks opened a new pull request #32300:
URL: https://github.com/apache/spark/pull/32300
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Removes PySpark version dependent codes from pyspark.pandas test codes.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There are several places to check the PySpark version and switch the logic, but now those are not necessary.
We should remove them.
We will do the same thing after we finish porting tests.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825235115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825058807
**[Test build #137817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137817/testReport)** for PR 32300 at commit [`c366309`](https://github.com/apache/spark/commit/c366309e8c74a6ec668f77cb3bbc7038156e328b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825209818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825217500
**[Test build #137829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137829/testReport)** for PR 32300 at commit [`0ecc1ac`](https://github.com/apache/spark/commit/0ecc1ac026b55ffb5f391291013c81aeb803c797).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825217500
**[Test build #137829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137829/testReport)** for PR 32300 at commit [`0ecc1ac`](https://github.com/apache/spark/commit/0ecc1ac026b55ffb5f391291013c81aeb803c797).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825243400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825313304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825224849
**[Test build #137829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137829/testReport)** for PR 32300 at commit [`0ecc1ac`](https://github.com/apache/spark/commit/0ecc1ac026b55ffb5f391291013c81aeb803c797).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825067556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin closed pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
ueshin closed pull request #32300:
URL: https://github.com/apache/spark/pull/32300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825309989
Thanks! merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825267924
Jenkins, retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825243387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825281451
**[Test build #137832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137832/testReport)** for PR 32300 at commit [`0ecc1ac`](https://github.com/apache/spark/commit/0ecc1ac026b55ffb5f391291013c81aeb803c797).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825216205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42357/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825305306
**[Test build #137832 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137832/testReport)** for PR 32300 at commit [`0ecc1ac`](https://github.com/apache/spark/commit/0ecc1ac026b55ffb5f391291013c81aeb803c797).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825189527
**[Test build #137827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137827/testReport)** for PR 32300 at commit [`5a66185`](https://github.com/apache/spark/commit/5a661853add1075fa697288eb6b027ee2a884400).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825037367
**[Test build #137817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137817/testReport)** for PR 32300 at commit [`c366309`](https://github.com/apache/spark/commit/c366309e8c74a6ec668f77cb3bbc7038156e328b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825190328
**[Test build #137827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137827/testReport)** for PR 32300 at commit [`5a66185`](https://github.com/apache/spark/commit/5a661853add1075fa697288eb6b027ee2a884400).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825281451
**[Test build #137832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137832/testReport)** for PR 32300 at commit [`0ecc1ac`](https://github.com/apache/spark/commit/0ecc1ac026b55ffb5f391291013c81aeb803c797).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825190345
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137827/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32300:
URL: https://github.com/apache/spark/pull/32300#discussion_r618765838
##########
File path: python/pyspark/pandas/tests/test_series.py
##########
@@ -857,15 +848,7 @@ def _test_value_counts(self):
)
def test_value_counts(self):
- if LooseVersion(pyspark.__version__) < LooseVersion("2.4"):
- with self.sql_conf({SPARK_CONF_ARROW_ENABLED: False}):
- self._test_value_counts()
- self.assertRaises(
- RuntimeError,
- lambda: ps.MultiIndex.from_tuples([("x", "a"), ("x", "b")]).value_counts(),
- )
- else:
- self._test_value_counts()
+ self._test_value_counts()
Review comment:
`_test_value_counts` is called just once. It is renamed to `test_value_counts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825309265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825073348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825313303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #32300:
URL: https://github.com/apache/spark/pull/32300#discussion_r618765465
##########
File path: python/pyspark/pandas/tests/indexes/test_base.py
##########
@@ -2249,13 +2235,7 @@ def test_to_list(self):
kmidx = ps.from_pandas(pmidx)
self.assert_eq(kidx.tolist(), pidx.tolist())
-
- if LooseVersion(pyspark.__version__) < LooseVersion("2.4"):
- # PySpark < 2.4 does not support struct type with arrow enabled.
- with self.sql_conf({SPARK_CONF_ARROW_ENABLED: False}):
- self.assert_eq(kmidx.tolist(), pmidx.tolist())
- else:
- self.assert_eq(kidx.tolist(), pidx.tolist())
+ self.assert_eq(kidx.tolist(), pidx.tolist())
Review comment:
Good catch! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #32300:
URL: https://github.com/apache/spark/pull/32300#discussion_r618619506
##########
File path: python/pyspark/pandas/tests/test_series.py
##########
@@ -857,15 +848,7 @@ def _test_value_counts(self):
)
def test_value_counts(self):
- if LooseVersion(pyspark.__version__) < LooseVersion("2.4"):
- with self.sql_conf({SPARK_CONF_ARROW_ENABLED: False}):
- self._test_value_counts()
- self.assertRaises(
- RuntimeError,
- lambda: ps.MultiIndex.from_tuples([("x", "a"), ("x", "b")]).value_counts(),
- )
- else:
- self._test_value_counts()
+ self._test_value_counts()
Review comment:
Do we call `self._test_value_counts()` somewhere else?
If not, we can just remove this and rename `_test_value_counts` to `test_value_counts`?
##########
File path: python/pyspark/pandas/tests/indexes/test_base.py
##########
@@ -2249,13 +2235,7 @@ def test_to_list(self):
kmidx = ps.from_pandas(pmidx)
self.assert_eq(kidx.tolist(), pidx.tolist())
-
- if LooseVersion(pyspark.__version__) < LooseVersion("2.4"):
- # PySpark < 2.4 does not support struct type with arrow enabled.
- with self.sql_conf({SPARK_CONF_ARROW_ENABLED: False}):
- self.assert_eq(kmidx.tolist(), pmidx.tolist())
- else:
- self.assert_eq(kidx.tolist(), pidx.tolist())
+ self.assert_eq(kidx.tolist(), pidx.tolist())
Review comment:
Seems like the same tests?
I guess the second one should be `kmidx.tolist()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825073348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825190345
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137827/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825037367
**[Test build #137817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137817/testReport)** for PR 32300 at commit [`c366309`](https://github.com/apache/spark/commit/c366309e8c74a6ec668f77cb3bbc7038156e328b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825216205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42357/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32300: [SPARK-35040][PYTHON] Remove Spark-version related codes from test codes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32300:
URL: https://github.com/apache/spark/pull/32300#issuecomment-825189527
**[Test build #137827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137827/testReport)** for PR 32300 at commit [`5a66185`](https://github.com/apache/spark/commit/5a661853add1075fa697288eb6b027ee2a884400).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org