[GitHub] [arrow] danepitkin commented on a diff in pull request #34611: GH-34610: [Java] Fix valueCount when loading NullVector

["danepitkin (via GitHub)" <gi...@apache.org>]

danepitkin commented on code in PR #34611:
URL: https://github.com/apache/arrow/pull/34611#discussion_r1192650781


##########
java/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:
##########
@@ -462,6 +462,13 @@ public void testUInt8Vector() {
     }
   }
 
+  @Test
+  public void testNullVector() {
+    try (final NullVector vector = new NullVector("v", 1024)) {
+      assertTrue(roundtrip(vector, NullVector.class));

Review Comment:
   Hmm, its not obvious to me why this test is failing. I would've expected your change to `loadFieldBuffers()` to work. Maybe the field comparison is failing? I think you could try passing a custom `TypeEqualsVisitor` with `checkName` or `checkMetadata` disabled to narrow things down on line 155.
   
   ```
   return VectorEqualsVisitor.vectorEquals(vector, imported, <custom_visitor_here>);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org