You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/14 19:01:38 UTC

[GitHub] [accumulo] DomGarguilo commented on pull request #2494: Remove faulty test: `SortedLogRecoveryTest.testMissingDefinition`

DomGarguilo commented on pull request #2494:
URL: https://github.com/apache/accumulo/pull/2494#issuecomment-1039443160


   > Did this code ever throw an exception in that case in the git history? If so, when and why did it change? Should it throw an exception?
   
   Yea it looks like it was changed from throwing and exception to logging [here](https://github.com/apache/accumulo/commit/ef9c0044e5e2de5e616c21527ed5df5baed3b254) which stems from [this Jira ticket](https://issues.apache.org/jira/browse/ACCUMULO-1033). According to the jira ticket, it was purposefully changed to logging. This was probably not picked up sooner because the test will always pass regardless of whether something is thrown or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org