You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/05/18 23:15:00 UTC
[jira] [Commented] (HBASE-24360) RollingBatchRestartRsAction loses
track of dead servers
[ https://issues.apache.org/jira/browse/HBASE-24360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110705#comment-17110705 ]
Hudson commented on HBASE-24360:
--------------------------------
Results for branch branch-2.3
[build #92 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/92/]: (x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/92/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/92/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/88/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/92/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RollingBatchRestartRsAction loses track of dead servers
> -------------------------------------------------------
>
> Key: HBASE-24360
> URL: https://issues.apache.org/jira/browse/HBASE-24360
> Project: HBase
> Issue Type: Test
> Components: integration tests
> Affects Versions: 2.3.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {{RollingBatchRestartRsAction}} doesn't handle failure cases when tracking its list of dead servers. The original author believed that a failure to restart would result in a retry. However, by removing the dead server from the failed list prematurely, that state is lost, and retry of that server never occurs. Because this action doesn't ever look back to the current state of the cluster, relying only on its local state for the current action invocation, it never realizes the abandoned server is still dead. Instead, be more careful to only remove the dead server from the list when the {{startRs}} invocation claims to have been successful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)