You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/12/22 16:38:54 UTC
[cordova-windows] 01/05: Conditionally skip the _one_ broken test
for VS 2017 (#330)
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a commit to branch brodybits-patchwip1
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git
commit cea0f134cdef6ff24ed21ec61335c289a44e39ef
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Fri Apr 26 14:20:16 2019 +0200
Conditionally skip the _one_ broken test for VS 2017 (#330)
...instead of allowing whole suite to fail.
---
appveyor.yml | 4 ----
spec/e2e/endtoend.spec.js | 18 ++++++++++--------
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 94a8d4c..2caf60c 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -31,10 +31,6 @@ environment:
- nodejs_version: "6"
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-matrix:
- allow_failures:
- - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-
install:
- ps: Install-Product node $env:nodejs_version
- npm install
diff --git a/spec/e2e/endtoend.spec.js b/spec/e2e/endtoend.spec.js
index f5a70d8..0ce205d 100644
--- a/spec/e2e/endtoend.spec.js
+++ b/spec/e2e/endtoend.spec.js
@@ -213,7 +213,16 @@ describe('Cordova create and build', function () {
// --release --bundle
- // here be 6a
+ it('spec.6a should generate appxupload and appxbundle for Windows 10 project bundle release build', function () {
+ // FIXME Fails for VS 2017 on AppVeyor
+ if (process.env.APPVEYOR_BUILD_WORKER_IMAGE === 'Visual Studio 2017') {
+ pending('This test is broken for VS 2017 on AppVeyor');
+ }
+
+ shell.exec(buildScriptPath + ' --release --bundle --archs=\"x64 x86 arm\"', { silent: silent });
+ _expectExist(/.*bundle\.appxupload$/, 3);
+ _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_Test', 'CordovaApp.Windows10_1.0.0.0_x64_x86_arm.appxbundle');
+ });
it('spec.6b should generate appxupload and appxbundle for Windows Phone 8.1 project bundle release build', function () {
shell.exec(buildScriptPath + ' --release --appx=8.1-phone --bundle --archs=\"x64 x86 arm\"', { silent: silent });
@@ -240,11 +249,4 @@ describe('Cordova create and build', function () {
_expectSubdirAndFileExist('CordovaApp.Phone_1.0.0.0_arm_Test', 'CordovaApp.Phone_1.0.0.0_arm.appx');
_expectSubdirAndFileExist('CordovaApp.Phone_1.0.0.0_x86_Test', 'CordovaApp.Phone_1.0.0.0_x86.appx');
});
-
- // this will be move up again when it is fixed for VS 2017 on AppVeyor
- it('spec.6a should generate appxupload and appxbundle for Windows 10 project bundle release build', function () {
- shell.exec(buildScriptPath + ' --release --bundle --archs=\"x64 x86 arm\"', { silent: silent });
- _expectExist(/.*bundle\.appxupload$/, 3);
- _expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_Test', 'CordovaApp.Windows10_1.0.0.0_x64_x86_arm.appxbundle');
- });
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org