You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2013/07/25 01:47:49 UTC
[jira] [Closed] (TAP5-1911) Tree leaf is still not selectable
[ https://issues.apache.org/jira/browse/TAP5-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1911.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.4
Assignee: Howard M. Lewis Ship
The Tree component was rewritten for 5.4; it now shows a visible checkbox next to selectable elements (the leafs of the tree).
> Tree leaf is still not selectable
> ---------------------------------
>
> Key: TAP5-1911
> URL: https://issues.apache.org/jira/browse/TAP5-1911
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.3.1, 5.3.2
> Reporter: Geoff Callender
> Assignee: Howard M. Lewis Ship
> Fix For: 5.4
>
>
> I can't make a tree leaf selectable. When I click on a leaf there's a javascript error in tree.js:
> function doAnimate(element) {
> var sublist = $(element).up('li').down("ul");
> var dim = sublist.getDimensions();
> tree.js:52TypeError: 'undefined' is not an object (evaluating 'sublist.getDimensions')
> var duration = Math.min(dim.height * cfg.ANIMATION_RATE,
> cfg.MAX_ANIMATION_DURATION)
> new Effect.toggle(sublist, cfg.TOGGLE_TYPE, {
> duration : duration,
> queue : {
> position : 'end',
> scope : cfg.QUEUE_NAME
> }
> });
> }
> It (sublist) is undefined because I clicked on 'tree_1', which has an 'li' up from it but no 'ul' down from there:
> <li>
> <span id="tree_1" class="t-tree-icon t-leaf-node t-tree-expanded"></span>
> <span class="t-tree-label t-selectable">
> 100 Philosophy
> </span>
> </li>
> I saw in TAP5-1629 that I have to provide a TreeSelectionModel if I want it to be selectable, and that is what I had done:
> <t:tree t:id="tree" t:model="treeModel" t:selectionModel="selectionModel"/>
> public TreeSelectionModel<CategoryNode> getSelectionModel() {
> if (selectionModel == null) {
> selectionModel = new DefaultTreeSelectionModel<CategoryNode>();
> }
> return selectionModel;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira